Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] use efficient startsWith implementation, don't check if ke… #29427

Merged

Conversation

DeepDiver1975
Copy link
Member

backport of #28213

@DeepDiver1975 DeepDiver1975 added this to the development milestone Nov 3, 2017
@DeepDiver1975 DeepDiver1975 self-assigned this Nov 3, 2017
@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #29427 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #29427   +/-   ##
===========================================
  Coverage        59.3%    59.3%           
  Complexity      17735    17735           
===========================================
  Files            1061     1061           
  Lines           59438    59438           
===========================================
  Hits            35251    35251           
  Misses          24187    24187
Impacted Files Coverage Δ Complexity Δ
...b/private/AppFramework/Utility/SimpleContainer.php 100% <100%> (ø) 17 <0> (ø) ⬇️
lib/private/ServerContainer.php 100% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2c70a...ca0803f. Read the comment docs.

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2017

I suppose this could be optimized further with custom code as we need to traverse the string multiple times, once for strrpos and then again for substr_count.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 97c5a7c into stable10 Nov 6, 2017
@PVince81 PVince81 deleted the stable10-3a057bef987bf8e5fdb0cfdaee73e75b5503b6cb branch November 6, 2017 13:43
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants