Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation in public sharing dialog doesn't have a good UX #29703

Closed
SergioBertolinSG opened this issue Nov 28, 2017 · 6 comments
Closed
Assignees
Milestone

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Nov 28, 2017

Steps to reproduce

  1. In the sharing options enable:
    Allow users to send mail notification for shared files
    and
    Allow users to send mail notification for shared files to other users.

  2. Open the dialog to share a file by link.

  3. Enter an invalid email in the field Send link via email.

Expected behaviour

The user is informed that the email introduced is not valid. Using a red font or a warning message before sending the request.

Actual behaviour

This field remains black:

screen shot 2017-11-28 at 15 26 43

And an error dialog appears informing that the email couldn't be sent (No validation before) :

screen shot 2017-11-28 at 14 08 15

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache

Database:
MySQL

PHP version:
7.1

Cache
DB

ownCloud version: (see ownCloud admin page)
(stable10)
{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.4.2","versionstring":"10.0.4 RC1","edition":"Community","productname":"ownCloud"}

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:


Are you using external storage, if yes which one: local/smb/sftp/...
No.

Are you using encryption:
No.

Logs


Client configuration

Browser
Chrome

cc @PVince81 , @felixheidecke

@pmaier1
Copy link
Contributor

pmaier1 commented Nov 28, 2017

This is a part of the ticket here #29694.
Agree with the expected behavior. The wording should be adapted to what is stated in the referenced ticket.

@felixheidecke
Copy link
Contributor

felixheidecke commented Dec 1, 2017

And an error dialog appears informing that the email couldn't be sent (No validation before)

The _sendMail Method checks for a valid email format but throws the same error as if it couldn't send even if it didn't try. I'll go ahead and extend my pending PR: #29721

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@PVince81 PVince81 modified the milestones: QA, planned Jan 12, 2018
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@PVince81
Copy link
Contributor

PVince81 commented Apr 3, 2018

should be fixed now

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants