-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email validation in public sharing dialog doesn't have a good UX #29703
Comments
This is a part of the ticket here #29694. |
The _sendMail Method checks for a valid email format but throws the same error as if it couldn't send even if it didn't try. I'll go ahead and extend my pending PR: #29721 |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
should be fixed now |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps to reproduce
In the sharing options enable:
Allow users to send mail notification for shared files
and
Allow users to send mail notification for shared files to other users.
Open the dialog to share a file by link.
Enter an invalid email in the field
Send link via email
.Expected behaviour
The user is informed that the email introduced is not valid. Using a red font or a warning message before sending the request.
Actual behaviour
This field remains black:
And an error dialog appears informing that the email couldn't be sent (No validation before) :
Server configuration
Operating system:
Ubuntu 16.04
Web server:
Apache
Database:
MySQL
PHP version:
7.1
Cache
DB
ownCloud version: (see ownCloud admin page)
(stable10)
{"installed":true,"maintenance":false,"needsDbUpgrade":false,"version":"10.0.4.2","versionstring":"10.0.4 RC1","edition":"Community","productname":"ownCloud"}
Updated from an older ownCloud or fresh install:
Fresh
The content of config/config.php:
Are you using external storage, if yes which one: local/smb/sftp/...
No.
Are you using encryption:
No.
Logs
Client configuration
Browser
Chrome
cc @PVince81 , @felixheidecke
The text was updated successfully, but these errors were encountered: