Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete thumbnails after file cache entry removal by scanner #30944

Closed
PVince81 opened this issue Mar 28, 2018 · 3 comments
Closed

Delete thumbnails after file cache entry removal by scanner #30944

PVince81 opened this issue Mar 28, 2018 · 3 comments

Comments

@PVince81
Copy link
Contributor

When dealing with external storages, there's the topic about remote update detection which is adressed partly by the scanner checking for new oc_filecache entries and discarding old ones.

Currently, when a file is deleted on an external storage outside of ownCloud, the scanner will later on find out about this deletion and delete the oc_filecache entry directly. In this situation, any thumbnail that was associated with this fileid still stays on-disk.

We should make sure that any associated file gets deleted automatically.

For previews, the preview system should listen to the scanner hook about deletion and then delete the matching thumbnails.

Optional addition: occ command to clear thumbnails.

Failing to do so can result in many gigabytes of orphaned thumbnails that need manual deletion.

Related:

@DeepDiver1975 @pmaier1 @jvillafanez @butonic

@PVince81 PVince81 added this to the backlog milestone Mar 28, 2018
@PVince81
Copy link
Contributor Author

cc @mmattel

@PVince81
Copy link
Contributor Author

additionally, once this is implemented we'll need a migration to clear the old orphaned thumbnails from before the system was in place (or just clear all)

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #27274 (delete), #5802 (Thumbnails should be deleted after file deletion), #205 (Files: thumbnails), #14671 (Thumbnail cache gets deleted after upload from smartphone), and #13824 (Delete File).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants