Cannot share with short user names

[PVince81]

Steps

1. Setup OC from stable10 (after Configurable minimum characters before autocomplete user searches #30313)
2. Create a user with id "tom"
3. Try sharing a folder with "tom" by typing these three letters

Expected result

Exact match found.

Actual result

The search did not start.

Version

stable10 9b49b21

@VicDeo @tomneedham @pmaier1 I think we should let the frontend send any search query starting with one character. However the backend will only return either exact matches for the number of characters, or provide a list of partial matches if the search string has the minimum number of configured characters as per #30313

[ownclouders]

GitMate.io thinks possibly related issues are #16903 (Sharing. It is not allowed to share a file with a user named with only one character), #2222 (Can't change shared Calendar entry by another user), #2219 (Can't change shared file by another user), #9544 (Can't Change Full Name for Users), and #29279 (cannot share with a user that has the same name as a group).

[VicDeo]

config.php:
'user.search_min_length' => 3,

[tomneedham]

what is the default unless specified @VicDeo ? did this change recently? we should keep the same behaviour - but we have some instances that want to be able to control this to stop expensive searches from happening.

[PVince81]

The default is 4 now. Still, I think we should let the frontend send a request to the server even for a single char. (this is especially important for chinese names that usually have 2 to 3 characters)

Then the backend can still do exact matches for these but restrict partial matches for minimum chars.
The fix is only about making the frontend have 1 char minimum and check that it actually works as intended.

[VicDeo]

@tomneedham default value is 4. Autocompletion started after the first character before this option was introduced.

[tomneedham]

As per chat I recommend:

• UI always sends request.
• Default min is 2
• Configurable to whatever as admins require

Why:

• This keeps at least most of the current behaviour.
• Admins that know / want to change this can do
• UI is able to work with low values

[PVince81]

@VicDeo so remove the option usage from the different UI parts and make it start at one character again. Let the backend enforce the limit.

[PVince81]

PR here: #31067

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.