Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance test code difference between stable10 & master #33499

Closed
individual-it opened this issue Nov 13, 2018 · 3 comments
Closed

acceptance test code difference between stable10 & master #33499

individual-it opened this issue Nov 13, 2018 · 3 comments

Comments

@individual-it
Copy link
Member

bootstrap/Sharing.php is different in master & stable10
code added in #22750 is missing in master

				if (\substr($field, 0, 10) === "share_with") {
					$value = \str_replace(
						"REMOTE",
						$this->getRemoteBaseUrl(),
						$value
					);
					$value = \str_replace(
						"LOCAL",
						$this->getLocalBaseUrl(),
						$value
					);
				}
				if (\substr($field, 0, 6) === "remote") {
					$value = \str_replace(
						"REMOTE",
						$this->getRemoteBaseUrl() . '/',
						$value
					);
					$value = \str_replace(
						"LOCAL",
						$this->getLocalBaseUrl() . '/',
						$value
					);
@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #31579 (test), #22485 (test), #22492 (test), #31517 ([stable10] Acceptance test coding standard changes), and #32892 ([stable10] Make targets for acceptance tests).

@phil-davis
Copy link
Contributor

I added this to the sprint - we should resolve this sort of crud "as soon as we notice it"

@individual-it
Copy link
Member Author

fixed by #33501

@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants