Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 external storage id always assumes Amazon is used #33649

Open
2 tasks
PVince81 opened this issue Nov 26, 2018 · 1 comment
Open
2 tasks

S3 external storage id always assumes Amazon is used #33649

PVince81 opened this issue Nov 26, 2018 · 1 comment
Labels
p3-medium Normal priority Type:Bug
Milestone

Comments

@PVince81
Copy link
Contributor

Nowadays people use S3 also outside of Amazon, for example with Minio instances.

However the current code is always assuming we're using Amazon and creates it id only based on the bucket name: https://github.com/owncloud/core/blob/v10.0.10/apps/files_external/lib/Lib/Storage/AmazonS3.php#L116

  • We should redesign the storage id to be composed of hostname + region + bucket name.

  • A migration must be written that converts all existing storage ids in oc_storages from S3 to the new format. This will need to iterate over all the external storage configurations.

@DeepDiver1975 @butonic

@PVince81 PVince81 added Type:Bug p3-medium Normal priority labels Nov 26, 2018
@PVince81 PVince81 added this to the backlog milestone Nov 26, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #14371 (Issue adding S3 External Storage), #10198 (External Only Storage), #13147 (External Storage S3 Very High Requests), #11652 (Amazon S3 not updating), and #26819 ([External Storage] Amazon S3 uploaded folders via AWS console are not available in ownCloud).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants