Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Backport: Added delay in search #34613

Merged
merged 1 commit into from Feb 26, 2019

Conversation

felixheidecke
Copy link
Contributor

@felixheidecke felixheidecke commented Feb 25, 2019

Description

Issue #31305 (To add delay to search operation)
I've added a delay of 500 milliseconds before the search results are showed in function $searchBox.keyup() .

Backporting: #32936

Motivation and Context

We don't want for the search results to be generated on every single keystroke .
That is why a wait (delay) is required to ascertain the user has stopped typing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Added proper indentation after review
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Feb 25, 2019
@phil-davis phil-davis merged commit a357e4d into stable10 Feb 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-adding-delay-to-search branch February 26, 2019 02:16
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants