Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/js/oc.js no browser cache #35993

Closed
cs35-owncloud opened this issue Aug 7, 2019 · 4 comments

Comments

@cs35-owncloud
Copy link

commented Aug 7, 2019

Hello,

I've noticed that the expires header was wrong and would never be cached on the browser side for the core/js/oc.js. You can check it on the demo. It seems it's hard coded in core/js/config.php at line 45/46. Is it possible to remove the no caching or at least set an expires that is useful at some point (or an other mechanism to invalidate the cache) ? It would also be great to minify the js but this point would be great for all the ressources, for example underscore.js.

Thanks.

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

This js File holds dynamic Data as well as user specific data. It shall never be cached.

@cs35-owncloud

This comment has been minimized.

Copy link
Author

commented Aug 7, 2019

Yes I agree also the content changes only when you login/logout, change your personal/admin settings. For a lambda user simply browsing files, uploading, it seems there is no modification. But agreed it seems like a chore to deal with a cache for a little improvement. Nevertheless minification would really be a plus.

Thanks.

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Nevertheless minification would really be a plus.

The owncloud frontend is based on really old techniques - we will not add any major changes here.
The new frontend (codename phoenix) will take care of such stuff.

@cs35-owncloud

This comment has been minimized.

Copy link
Author

commented Aug 7, 2019

Understood, thanks for your answer and your time !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.