Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour changes due to "Move user creation to a separate service" #36019

Open
phil-davis opened this issue Aug 13, 2019 · 3 comments
Open

Behaviour changes due to "Move user creation to a separate service" #36019

phil-davis opened this issue Aug 13, 2019 · 3 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Aug 13, 2019

After PR #35972 was merged to core master, password_policy tests started to fail due to some small changes in error reporting behaviour. See owncloud/password_policy#241 for the detailed test scenario changes needed.

  1. When adding a user via the Provisioning API, if there is a PolicyException (e.g. the password does not meet some password policy requirement) then the OCS status message has the text Unable to create user due to exception: prepended to it - e.g.
Unable to create user due to exception: The password contains too few lowercase letters. At least 3 lowercase letters are required.

Previously the OCS status text was just:

The password contains too few lowercase letters. At least 3 lowercase letters are required.

Note: when changing a user's password via the Provisioning API the messages have not changed - the extra bit about the exception does not appear.

  1. When adding a user using the occ command, then the text messages are unchanged. But they are coming on stdout rather than stderr.

Note: when changing a user password the error messages are still coming on stderr

What to do about each of these behaviour changes, and the inconsistencies between "add user" and "change password"?

@phil-davis
Copy link
Contributor Author

phil-davis commented Aug 13, 2019

@sharidas @micbar @DeepDiver1975 ?

I added to Server 10.3 project, because this needs to be discussed and either accepted or changed/fixed before release.

@PVince81
Copy link
Contributor

Sounds like a regression.

@sharidas please make the status text look like it was before

@micbar
Copy link
Contributor

micbar commented Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants