Test: the fields of the last response should not include does not work with 'expiration' field

[skshetry]

The following step does not work if we try to check for ANY_VALUE:

Then the fields of the last response should not include
  | expiration | ANY_VALUE |

Analysis:

This is due to how strtotime() works. This needs to be handled somewhere here:

core/tests/acceptance/features/bootstrap/Sharing.php

Lines 662 to 671 in f37a6dc

	if ((string) $field === 'expiration' && !empty($contentExpected)) {
	$contentExpected
	= \date(
	'Y-m-d',
	\strtotime(
	$contentExpected,
	$this->getServerShareTimeFromLastResponse()
	)
	) . " 00:00:00";
	}

strtotime is passed ANY_VALUE which when fails returns FALSE. That, when passed to date()
returns the Unix epoch (i.e. 1st January 1970), and the content to assert is no longer ANY_VALUE.

This when passed to doesFieldValueMatchExpectedContent() then returns false even though the field is still there.

core/tests/acceptance/features/bootstrap/Sharing.php

Lines 629 to 645 in f37a6dc

	public function doesFieldValueMatchExpectedContent(
	$field, $value, $contentExpected, $expectSuccess = true
	) {
	if (($contentExpected === "ANY_VALUE")
	|| (($contentExpected === "A_TOKEN") && (\strlen($value) === 15))
	|| (($contentExpected === "A_NUMBER") && \is_numeric($value))
	|| (($contentExpected === "AN_URL") && $this->isAPublicLinkUrl($value))
	|| (($field === 'remote') && (\rtrim($value, "/") === $contentExpected))
	|| ($contentExpected === $value)
	) {
	if (!$expectSuccess) {
	echo $field . " is unexpectedly set with value '" . $value . "'\n";
	}
	return true;
	}
	return false;
	}

[phil-davis]

@skshetry do you need this for your current user-group-expiration date work?
Are you going to repair it right away, or is it difficult?

[phil-davis]

@skshetry done?

[skshetry]

@phil-davis, it's not in master, yet. I'll close as soon as it gets into master.