1.6.0-beta1 chunked upload fails for 5.0.14a

[moscicki]

The client complains about the lack of X-OC-MTIME extension on the server ("ownCloud 5 is required").

The normal upload (<10MB) works fine.

I guess the problem is the lack of X-OC-MTIME header in server's response for chunked upload.

[DeepDiver1975]

@moscicki I assume this happens on files bigger than 10MB? Within the OC5 code base we do not send the http header back in the response. This has been fixed with OC6

[moscicki]

Yes, bigger than 10MB...

Interestingly, the client 1.5.x works fine...

[DeepDiver1975]

@danimo @dragotin can you please have a look at this?

@moscicki how does the error/notification look like you are receiving? screenshot welcome - thx

[dragotin]

@ogoffart did we change the name of the header or something that might affect the comparably old ownCloud? @moscicki in wireshark or mitmproxy you can see easily if and what header comes back from server. Can you do that for us?

[moscicki]

I think server simply does not return header[ "X-OC-MTime" ]: "accepted" for chunked PUT.

And you probably ignored this in 1.5 clients until now (my guess).

Here you have two examples: BIG -- chunked upload, and SMALL - which works fine.

This is QNAM propagator.

https://box.cern.ch/public.php?service=files&t=12fae4628fb4e12900e510d893457ea7

kuba

On Apr 29, 2014, at 1:27 PM, dragotin notifications@github.com wrote:

@ogoffart did we change the name of the header or something that might affect the comparably old ownCloud? @moscicki in wireshark or mitmproxy you can see easily if and what header comes back from server. Can you do that for us?

—
Reply to this email directly or view it on GitHub.

[ogoffart]

ah. 1.5 client still supported owncloud 0.4.5. and was doing a PROPPATC/PROPFIND after a PUT if the X-OC-MTime wa snot there.
1.6 assumed that X-OC-MTime is present.
I tought that owncloud 5 had it all the time. But apparently not with chunks :-/

I guess we will have to handle that.

Question: does owncloud 5 actually set the correct mtime and just don't set the header? In that case we could just ignore this header totally and assume the server does the right thing. But if the owncloud server does not properly set the mtime, then we will have to do PROPPATCH

[dragotin]

@DeepDiver1975 do you know the answer to @ogoffart question? IIRC we implemented that the server takes the mtime out of the PUT header together with returning a header X-OC-MTime to kind of acknowledge that, which would mean that the answer is no to the question. We will have to implement the setting of the mtime separately.

[moscicki]

when is the 1.6 production release due?

maybe by that time we would have moved to owncloud 6 -- and at least for us that would not be a problem anymore.

[DeepDiver1975]

@DeepDiver1975 do you know the answer to @ogoffart question? IIRC we implemented that the server takes the mtime out of the PUT header together with returning a header X-OC-MTime to kind of acknowledge that, which would mean that the answer is no to the question. We will have to implement the setting of the mtime separately.

For chunked upload we NOT respect the MTIME header - unfortunately.

[dragotin]

thanks @ogoffart

[ser72]

@dragotin @ogoffart

What release of client was this fixed in?

Will it work with 5.0.15?

[ogoffart]

this was fixed in 1.6, but i think there was others bugs in 1.6 related to owncluod 5 that are only going to be in 1.6.2