Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to theme non-core app assets in app-themes #1338

Open
2 of 12 tasks
VicDeo opened this issue Jun 23, 2019 · 8 comments
Open
2 of 12 tasks

Document how to theme non-core app assets in app-themes #1338

VicDeo opened this issue Jun 23, 2019 · 8 comments
Labels
developer docs enhancement New feature or request p4-low Low priority question Further information is requested

Comments

@VicDeo
Copy link
Member

VicDeo commented Jun 23, 2019

What Needs to be Documented?

Theming apps

  1. create directory apps under your theme:
    owncloud/apps/theme-example/apps
  2. create a directory for the asset you want to theme under the newly created directory:
    owncloud/apps/theme-example/apps/files_sharing/img
  3. Put custom folder-waiting.svg into owncloud/apps/theme-example/apps/files_sharing/img

Note: do not copy the entire app, only the needed assets

Where Does This Need To Be Documented?

https://doc.owncloud.org/server/10.0/developer_manual/core/theming.html

Why Should This Change Be Made? (Optional)

To clarify app-theming for developers

What Type Of Content Change Is This? (Optional)

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

Which Manual Does This Relate To? (Optional)

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other

Ref owncloud/core#35623

@voroyam
Copy link
Contributor

voroyam commented Jul 22, 2019

@ChrisEdS can you test this and then we can document this together?

@settermjd
Copy link
Contributor

@ChrisEdS, any progress on this one?

@ChrisEdS
Copy link
Contributor

Sorry, completely missed this ticket. When's the next time you'll be in the office? @settermjd

@settermjd
Copy link
Contributor

Should be there on Thursday, @ChrisEdS.

@settermjd
Copy link
Contributor

@settermjd
Copy link
Contributor

@settermjd settermjd added question Further information is requested Effort: 0.25d p4-low Low priority and removed waiting on feedback labels Mar 3, 2020
@VicDeo
Copy link
Member Author

VicDeo commented Mar 10, 2020

@settermjd Currently it has a sample for the core assets only and it's not obvious that theming of apps is also possible
it would be good to have examples for the following cases

  • any app from shipped apps apps directory
  • any app from a custom apps directory

@settermjd
Copy link
Contributor

@settermjd Currently it has a sample for the core assets only and it's not obvious that theming of apps is also possible
it would be good to have examples for the following cases

  • any app from shipped apps apps directory
  • any app from a custom apps directory

Thanks for the further reply, @VicDeo. I'll try and get that implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer docs enhancement New feature or request p4-low Low priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants