Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big File upload docs need to be updated #1707

Closed
3 of 12 tasks
enbrnz opened this issue Aug 23, 2019 · 4 comments · Fixed by #1731
Closed
3 of 12 tasks

Big File upload docs need to be updated #1707

enbrnz opened this issue Aug 23, 2019 · 4 comments · Fixed by #1731
Assignees
Labels
p3-medium Normal priority work in progress Still in development. Not to be merged.

Comments

@enbrnz
Copy link
Contributor

enbrnz commented Aug 23, 2019

First the document I'm talking about:
Big File Upload Configuration

Following a discussion in central, I noticed that the information inside this documentation article is "a little" dated. Perhaps it would be a good idea to go through it piece by piece and overhaul it.

For example:

The default maximum file size for uploads, in ownCloud, is 512MB.

This might be correct for unchunked uploads, but these only occur in very specific edge cases nowadays. So the default is now that there is no maximum file size as even uploads through the WebUI are chunked.

32Bit OS-architecture

I think we can assume now that most OSs are 64bit

Make sure that the latest version of PHP (at least 5.6) is installed

This is just wrong, as the latest version is PHP 7.4 and we only start supporting PHP 7.3 with the upcoming release of oC 10.3. On top of that, the mentioned PHP 5.6 is no longer supported since a few releases.

Aside from fixing the existing content I would like to submit an addition:
For very long running uploads (>1hr) into public folders (no chunking), 'filelocking.ttl' should be set to something very large (maximum file size / slowest assumed connection = time in seconds).
I've written down a little bit more about that in central, otherwise please ask me if you need more information.

What Type Of Content Change Is This?

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

Which Manual Does This Relate To?

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other
@enbrnz enbrnz added the p3-medium Normal priority label Aug 23, 2019
@enbrnz enbrnz assigned enbrnz and unassigned enbrnz Aug 23, 2019
@settermjd
Copy link
Contributor

All sounds good to me. @PVince81, can we get this into a sprint, pls?

@settermjd settermjd self-assigned this Sep 2, 2019
@settermjd settermjd added the work in progress Still in development. Not to be merged. label Sep 2, 2019
@settermjd
Copy link
Contributor

@enbrnz, wrt your formula in central, time in seconds = (maximum file size / slowest assumed connection), can you clarify "slowest assumed connection", pls?

@voroyam
Copy link
Contributor

voroyam commented Sep 4, 2019

I don't know what Erik meant, but I assume if for example you have a 50 000 DSL Internet Connection.

Then the slowest speed would be 25 000 kb/s or 3.1 Mb/s. (Your internet speed may always fluctuate depending on the time of day and the network load in your area. But the Internet Provider is bound by law to provide at least 50% of what he sold you. So 50/2=25.)

So now lets assume you want to upload a 100 MB Video File.
Then we divide 100 with 3.1 and get something like 30 seconds. for the TTL setting.

IF you want to upload 2 GB then you simply convert that in MB and get 2000 MB and put that in the formula.

@enbrnz
Copy link
Contributor Author

enbrnz commented Sep 10, 2019

We had a case where somebody was uploading on an 8Mbit/s (Download) DSL line, so the upload was even less. And they needed to upload large files (> 1GB), so the upload would take longer than 1hr.

If you need to provide uploads that take longer than that, you need to adjust the filelocking.ttl configuration to accommodate for that.

My formula is there in order to be able to provide a rough estimate of the minimum time you need to set in order for it to work.

Please note though that this is only required for unchunked uploads, like in a public folder without login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority work in progress Still in development. Not to be merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants