Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Update how to enable the recovery key password for version 10.0. #2938

Merged
merged 3 commits into from
Jun 29, 2018

Conversation

settermjd
Copy link
Contributor

@settermjd settermjd commented Mar 16, 2017

This PR:

  • Updates the documentation, showing how to enable the recovery key password in version 10.0.

Relates To

#2937

@settermjd settermjd added this to the 10.0 milestone Mar 16, 2017
@settermjd settermjd self-assigned this Mar 16, 2017
@settermjd settermjd requested a review from butonic March 16, 2017 10:21
@mention-bot
Copy link

@settermjd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vgezer and @phil-davis to be potential reviewers.

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@settermjd the new screensot shows the admin section to set the recovery key. users should also see an encryption section, but owncloud/core#27398

@settermjd
Copy link
Contributor Author

@butonic good point. How about we leave this as is, but don't merge it until the bug is fixed?

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

needs rebase

@settermjd
Copy link
Contributor Author

@PVince81 did a merge. Should have rebased.

@settermjd
Copy link
Contributor Author

Is there an installation where the fix can be tested on? I do most of my review work now with the official ownCloud Docker image; and it doesn't contain the change, as it's not been backported to 10.0.2.

@settermjd
Copy link
Contributor Author

@PVince81 In a build based on the latest master branch, that fix is either not there, or the fix doesn't work. :-(

@settermjd
Copy link
Contributor Author

@PVince81 can you provide further input please?

@PVince81
Copy link
Contributor

@sharidas can you help here ? ^

@sharidas
Copy link
Contributor

sharidas commented Jul 25, 2017

Pre condition:

  • clone core and encryption repo respectively and switch to master branch.
  • user keys enabled for encryption
  • normal users created in oC

Now as a normal user when logged in navigate to Settings -> Encryption the below screenshot can be seen:
normal_user_settings_passwordrecovery

This would help users when the passwords are lost. @settermjd Let me know if this screenshot helps you? Else please ping me so that I can share more details required.

@settermjd
Copy link
Contributor Author

Thanks for the feedback @sharidas.

@settermjd settermjd modified the milestones: Weekly Sprint :: July 17 - 21, Weekly Sprint :: July 24 - 28 Jul 28, 2017
@settermjd settermjd removed this from the Weekly Sprint :: July 17 - 21 milestone Jul 28, 2017
@mmattel
Copy link
Contributor

mmattel commented Nov 17, 2017

@settermjd Is there any update on this PR ?

@settermjd
Copy link
Contributor Author

Hey @mmattel, because of the "On Hold" label I've not looked at this issue in some time. I'll have a review now.

@settermjd settermjd removed the On Hold label Jan 31, 2018
@settermjd
Copy link
Contributor Author

Trying again, with the latest copy of master.

@settermjd
Copy link
Contributor Author

@sharidas @mmattel just updated the image. Please let me know if it's ok to merge.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit faa3627 into master Jun 29, 2018
@PVince81 PVince81 deleted the update-recovery-key-settings-for-10.0.0 branch June 29, 2018 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants