-
Notifications
You must be signed in to change notification settings - Fork 168
Update how to enable the recovery key password for version 10.0. #2938
Conversation
@settermjd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vgezer and @phil-davis to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@settermjd the new screensot shows the admin section to set the recovery key. users should also see an encryption section, but owncloud/core#27398
@butonic good point. How about we leave this as is, but don't merge it until the bug is fixed? |
needs rebase |
@PVince81 did a merge. Should have rebased. |
Is there an installation where the fix can be tested on? I do most of my review work now with the official ownCloud Docker image; and it doesn't contain the change, as it's not been backported to 10.0.2. |
@PVince81 In a build based on the latest master branch, that fix is either not there, or the fix doesn't work. :-( |
@PVince81 can you provide further input please? |
@sharidas can you help here ? ^ |
Pre condition:
Now as a normal user when logged in navigate to This would help users when the passwords are lost. @settermjd Let me know if this screenshot helps you? Else please ping me so that I can share more details required. |
Thanks for the feedback @sharidas. |
@settermjd Is there any update on this PR ? |
Hey @mmattel, because of the "On Hold" label I've not looked at this issue in some time. I'll have a review now. |
Trying again, with the latest copy of master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR:
Relates To
#2937