Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Recommend tests/unit for php tests with same namespace #3889

Closed
wants to merge 1 commit into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 9, 2018

  • added unit to test path for php tests
  • recommended same namespace
  • reordered code sections
  • updated links

@butonic
Copy link
Contributor Author

butonic commented May 29, 2018

ping @patrickjahns

@settermjd settermjd added the WIP label Jun 1, 2018
@settermjd
Copy link
Contributor

@patrickjahns, is this going anywhere?

@patrickjahns
Copy link
Contributor

@DeepDiver1975 @phil-davis @PVince81
Would be great to get your input - I think this is another step in the right direction to clarify how we want to develop at ownCloud.

This is also a bit of owncloud/coding-standard#17 - where we talk about code styles. But in general we might take the time to also define, how ownCloud repositories and content shall be structured ( and maybe also apply some of the common project styles from the php community )

@phil-davis
Copy link
Contributor

phil-davis commented Nov 19, 2018

The folder naming here matches what is being done in "current" apps. Under tests we have acceptance, unit and sometimes integration folders.

Others can comment on the unit test naming conventions - but it looks good and standard to me.

@settermjd
Copy link
Contributor

Closing, as this has been ported to the new docs.

@settermjd settermjd closed this Feb 5, 2019
@settermjd settermjd deleted the update-unit-test-recommendation branch February 5, 2019 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants