Antivirus update #111
Antivirus update #111
Conversation
|
By analyzing the blame information on this pull request, we identified @artem-sidorenko, @fsbruva and @DeepDiver1975 to be potential reviewers |
VicDeo
force-pushed
the
antivirus-update
branch
2 times, most recently
from
ff8b32c
to
dff445c
Compare
VicDeo
force-pushed
the
antivirus-update
branch
2 times, most recently
from
17f982c
to
a0b6395
Compare
VicDeo
force-pushed
the
antivirus-update
branch
5 times, most recently
from
662e460
to
6714a60
Compare
|
@icewind1991 may I ask you to review this PR? |
| $qb->expr()->like('fc.path', $qb->expr()->literal('files/%')) | ||
| ) | ||
| ->andWhere( | ||
| $qb->expr()->neq('fc.size', '?1') |
|
Looks good otherwise |
|
@VicDeo from the IRC discussion it seems that this fix is critical to make antivirus work again with OC >= 9.0 ? |
|
@VicDeo how to test ? Is this only about background scanning, not upload time scanning ? CC @owncloud/qa |
|
Will need backport to 9.0 and 9.1 |
|
@PVince81 it doesn't fix backround job itself, but a couple of other issues (see the first message) Fix saving rules at admin page
Expected: changes are saved Also it moves adding a cron task to the install script instead of adding it any time app.php is executed. |
|
Doesn't work for me. 👎 The rule is not saved. Also if the save button is required also for rules, it should be duplicated or moved to the bottom of the antivirus section. Otherwise it is a bad UX. BTW what is the difference in rules between "Infected" and "Clean" ? |
It is not. It saves non-advanced section.
If av binary/socket/etc response contains something that matches "Infected" rule, the file is considered to be infected. In no rules matched the file status is unknown. |
|
OK, I didn't understand the interface. I suggest an icon change, something like ✅ for me doesn't look like a save button. Filed here in a different issue #115 👍 |
| $qb->expr()->eq('fc.storage', 'ss.numeric_id'), | ||
| $qb->expr()->orX( | ||
| $qb->expr()->like('ss.id', $qb->expr()->literal('local::%')), | ||
| $qb->expr()->like('ss.id', $qb->expr()->literal('home::%')) |
There was a problem hiding this comment.
note: this won't work for md5 storage ids https://github.com/owncloud/core/wiki/Storage-IDs#random-numberstring
Will need separate fixing.
The way how repair steps do is iterate over all users and get their home storages... yes, cumbersome.
There was a problem hiding this comment.
Ah, and starting with OC 9.0 it will be possible to found the home mount from the oc_mounts table
|
Code looks good 👍 Needs backport ? |
|
@PVince81 yes, otherwise rules in advanced section are not changed/deleted |
===, remove deprecated calls