Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery overview is missing #102

Closed
jnweiger opened this issue Jul 22, 2019 · 25 comments · Fixed by #310
Closed

Gallery overview is missing #102

jnweiger opened this issue Jul 22, 2019 · 25 comments · Fixed by #310
Assignees
@felixheidecke @pmaier1
Labels
enhancement New feature or request

Comments

@jnweiger
Copy link
Contributor

Seen on damkencloud:

The old gallery had a tiled view which gives a nice overview of all images in a folder:

e.g.
image

When we install files_mediaviewer then this overview is gone. That is a regression.
@DeepDiver1975
Copy link
Member

Media Viewer is a replacment for the Gallery. Install Gallery and you are fine.

Missing tile Overview is a feature requests which need to be opened and addressed.

@jnweiger
Copy link
Contributor Author

@DeepDiver1975 there is a contradiction: If mediaviewer replaces gallery, then I cannot install both. I am not fine.
@pmaier1 @hodyroff Please confirm this is an intended regression or reopen.

@jnweiger
Copy link
Contributor Author

@pmaier1 confirms this is missing in the current version.
-> Feature.

@jnweiger jnweiger reopened this Jul 22, 2019
@jnweiger jnweiger added the enhancement New feature or request label Jul 22, 2019
@cs35-owncloud
Copy link

Hello,
indeed it was a nice feature, it would be great to have it back !
Thanks.

@DeepDiver1975 DeepDiver1975 changed the title files_mediaviewer disales gallery oververiew Gallery overview is missing Aug 6, 2019
@mv1005
Copy link

mv1005 commented Aug 6, 2019 •
edited

Hello,
to be honest, to me it looks like there is some misconception with the transition from Gallery to Media Viewer. Gallery provided two things: A directory view (thumbnails) and an image viewer (when clicking a picture). The Media Viewer for some reason completely dropped the directory view (no thumbnails any more, just default file view) and replaced the image viewer with a media viewer just dropping two key features of the old image viewer: hires full screen support and timed slideshow.

To me it is absolutely unobvious why the Media Viewer is advertised as the all new and better image viewer (https://owncloud.org/news/good-bye-gallery-say-hi-to-the-new-media-viewer/).

Don't take me wrong, I absolutely acknowledge the development effort spent on the new app, it looks clean and polished, but unfortunately is just missing (to me) key features.

I would really appreciate to have back the thumbnail view and the full screen image slideshow.

@TDannhauer
Copy link

I agree,
The missing directory (thumbnail) view is a showstopper for me. I‘ll stay with gallery until is added in this app as well.

@kblaschke
Copy link

Additionally, the Gallery app doesn't work anymore in OwnCloud 10.3+, so there's no choice going back to the old one until the missing features are implemented.

For me, the most useful feature was the directory thumbnail view, even if it had serious performance issues with large amounts of pictures.

@PVince81
Copy link
Contributor

AFAIK the gallery app should still work with 10.3 as there were no changes in API.

cc @micbar

@micbar
Copy link
Contributor

micbar commented Oct 30, 2019

@pmaier1 AFAIK the mediaviewer and Gallery apps should not be installed in parallell.

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 30, 2019

Generally speaking, there are plans for the new web frontend for ownCloud (https://github.com/owncloud/phoenix) to integrate a grid view toggle for the file list. This will allow users to generally switch between different sizes/views for the files list.

@micbar
Copy link
Contributor

micbar commented Oct 30, 2019

What about the current users?
Obviously they would like a gallery view.
So either they should run both apps in parallel or we need a gallery view for mediaviewer?

@TDannhauer
Copy link

@micbar : agreed. I won‘t upgrade until a gallery view is available in the media viewer.

@pmaier1 : the benefit of the old grid view was that there is nothing to configure, you can give the grid view URL to foreign users which have no OC experience. Don‘t make it highy customizable - make it easy.
For the use case: Imagine you want to share photos with your grandma. Even only 5 button presses to customize are too much for her.

Thanks!

@jnweiger jnweiger mentioned this issue Jan 7, 2020
Open
@hurradieweltgehtunter
Copy link
Contributor

Push
Comments on oc.org show too that this is a highly missing feature.
We also promoted the media viewer as replacement for gallery in the blogpost (https://owncloud.org/news/good-bye-gallery-say-hi-to-the-new-media-viewer/)

This should be added with higher prio IMHO.

@Matthiasfranck
Copy link

Hi,

I really like owncloud in general. Also the media viewer is awesome. The only thing I am missing is this overview of pictures. This is really important for people who use their owncloud server to share images. I would love to see this come back.

@silvain
Copy link

silvain commented Jun 11, 2020

The gallery view we had with Gallery is absolutely essentiel for me. Unfortunately, this media viewer misses this feature and is incompatible with Gallery, so that I have to disable the media viewer in my owncloud installations, in spite of it's other advantages.

@cdamken cdamken assigned pmaier1 and unassigned cdamken Jul 14, 2020
@pcros
Copy link

pcros commented Aug 31, 2020

Same thing here : I won't be able to use the (brilliant) media viewer till it has this tile view feature :-/ as my users need it.

@RossRogers
Copy link
Contributor

When both Gallery and files_mediaviewer are enabled, the Gallery plugin doesn't work. In the javascript console, I see:

Uncaught TypeError: Cannot read property 'registerAction' of undefined

If I modify app/files_mediaviewer/js/files_mediaviewer_init.js so that:

OCA.Files.fileActions.registerAction(r),OCA.Files.fileActions.setDefault(t,e.name)

becomes:

OCA.Files.fileActions &&OCA.Files.fileActions.registerAction(r),OCA.Files.fileActions&&OCA.Files.fileActions.setDefault(t,e.name)

Then it doesn't error out any more since it is checking for the fileActions field before proceeding and the Gallery works.

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Oct 23, 2020 •
edited

@RossRogers Would you mind opening a PR?
@micbar seems this could be a solution?

RossRogers added a commit to RossRogers/files_mediaviewer that referenced this issue Oct 23, 2020
@RossRogers
Possibly fix Gallery & files_mediaviewer compatibility issue.
9bd14a1 
This simple, no-harm change checks that `OCA.Files.fileActions` exists
before using it.  This seems to fix owncloud#102, the compatibility issue between the
files_mediaviewer app and the old Gallery app.  The edit allows
javascript to continue without throwing an exception if
`OCA.Files.fileActions` does not exist.  For some reason this happens
when both Gallery and files_mediaviewer are enabled in my installation
of OwnCloud.
@RossRogers RossRogers mentioned this issue Oct 23, 2020
Merged
@RossRogers
Copy link
Contributor

@hurradieweltgehtunter Done. However, I'm not sure if the edit fixes it for everyone. I know it fixed it for me. Regardless of if it fixes the problem for everyone, the edit itself causes no harm upon inspection if it doesn't solve the problem for other folks.

@hurradieweltgehtunter
Copy link
Contributor

Thank you @RossRogers
I'll forward this to our devs for further inspection.

@silvain
Copy link

silvain commented Oct 26, 2020 via email

@hurradieweltgehtunter
Copy link
Contributor

While we're testing this internally could someone test this on their own and report if this fixes things? Would be a great help.

@TDannhauer
Copy link

TDannhauer commented Dec 28, 2020 •
edited

@hurradieweltgehtunter : I tested it with the latest release 10.6.0 and the gallery app works again

@hurradieweltgehtunter
Copy link
Contributor

Thank you all for your help. App including fix is in the release pipeline: #324

@jnweiger
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixheidecke felixheidecke

@pmaier1 pmaier1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Possibly fix Gallery & files_mediaviewer compatibility issue. RossRogers/files_mediaviewer