Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links doesnt come up in new Tab or Window #296

Closed
GeraldLeikam opened this issue Sep 9, 2021 · 1 comment · Fixed by #301
Closed

Links doesnt come up in new Tab or Window #296

GeraldLeikam opened this issue Sep 9, 2021 · 1 comment · Fixed by #301

Comments

@GeraldLeikam
Copy link
Contributor

GeraldLeikam commented Sep 9, 2021 •
edited

In version v1.0.0rc1 of the files_pdfviewer, the links are not opened in a new tab or window but replace the content of the tab with the opened document.

Screenshot_2021-09-09_14-45-11
Screenshot_2021-09-09_14-45-46

Occurs on the following browsers:

MS Internet Explorer
FireFox
Chrome
Android FireFox (doesn' work at all. see -> #298 )
Android Chrome (doesn' work at all. see -> #298 )

Safari and iOS Safari are still being tested.
As soon as these are tested I will update this issue.
@GeraldLeikam GeraldLeikam changed the title Links doesnt come up in new Tab od Window Links doesnt come up in new Tab or Window Sep 9, 2021
@GeraldLeikam GeraldLeikam mentioned this issue Sep 9, 2021
Closed
9 tasks
@AlexAndBear
Copy link

AlexAndBear commented Sep 17, 2021 •
edited

mozilla/pdf.js#14033

@AlexAndBear AlexAndBear mentioned this issue Sep 17, 2021
Merged
AlexAndBear pushed a commit that referenced this issue Sep 17, 2021
Merge pull request #301 from /issues/296
6859f94 
Fix external links not opened in a new tab
@AlexAndBear AlexAndBear linked a pull request Sep 17, 2021 that will close this issue
Fix external links not opened in a new tab / language "Deutsch (persönlich)" not translated #301
Merged
@GeraldLeikam GeraldLeikam mentioned this issue Oct 7, 2021
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AlexAndBear @GeraldLeikam