-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pdfjs to v2.9 #288
Update pdfjs to v2.9 #288
Conversation
3066116
to
58621ea
Compare
Ready to review |
ff2c53a
to
62017b4
Compare
62017b4
to
7455cc4
Compare
I'm not sure if falling back to download the file is a good idea. It might be better to show a "your browser isn't supported" notification. The problem I see is that the behaviour is very different: I'm on my phone / tablet, touch the file and it opens the pdf, however when I'm on the office using IE 11 (company policy) and I click the file, it downloads instead of opening. It seems like a bug to me. |
@jvillafanez this has been discussed with @hodyroff and @tbsbdr as files_mediaviewer does the same, the decision was made. |
I still think there will be bug reports incoming complaining about the behaviour, but if it was decided... 🤷♂️ |
Kudos, SonarCloud Quality Gate passed! |
Description
Fixes
#286
#258
https://github.com/owncloud/enterprise/issues/4680
Might fix:
#275
Screenshots
Before:
After: