Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfjs to v2.9 #288

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Update pdfjs to v2.9 #288

merged 2 commits into from
Aug 6, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Aug 4, 2021

Description

  • Update pdfjs from v2.5 to v2.9 (which enabled signature support)
  • Drop support for IE and non-chromium-based EDGE due to pdfjs cancel support since v2.7
    • Download will be started instead of opening with files_pdfviewer while click on a pdf file
    • Context menu item 'Open in PDFViewer' won't be displayed anymore

Fixes

#286
#258
https://github.com/owncloud/enterprise/issues/4680

Might fix:
#275

Screenshots

Before:
image

After:
image

js/workersrc.js Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2021

CLA assistant check
All committers have signed the CLA.

@AlexAndBear AlexAndBear changed the title proto the prototype Update pdfjs to v2.9 Aug 4, 2021
@JammingBen JammingBen marked this pull request as ready for review August 4, 2021 14:37
@AlexAndBear
Copy link
Author

Ready to review

@jvillafanez
Copy link
Member

I'm not sure if falling back to download the file is a good idea. It might be better to show a "your browser isn't supported" notification. The problem I see is that the behaviour is very different: I'm on my phone / tablet, touch the file and it opens the pdf, however when I'm on the office using IE 11 (company policy) and I click the file, it downloads instead of opening. It seems like a bug to me.
At least, with the notification, the user knows what happens and can choose between downloading the file or use a different browser to open the file.

@AlexAndBear
Copy link
Author

AlexAndBear commented Aug 6, 2021

@jvillafanez this has been discussed with @hodyroff and @tbsbdr as files_mediaviewer does the same, the decision was made.
I brought in the same objection as you in the first place ;) I think I might show a console.warning

@jvillafanez
Copy link
Member

I still think there will be bug reports incoming complaining about the behaviour, but if it was decided... 🤷‍♂️

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants