Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist all domains for image #65

Merged
merged 3 commits into from Sep 18, 2015
Merged

Conversation

LukasReschke
Copy link
Member

Fixes #63 and #60 and #66

@LukasReschke LukasReschke added this to the 8.2-current milestone Sep 9, 2015
@LukasReschke
Copy link
Member Author

PHP Fatal error:  Uncaught exception 'OCP\AutoloadNotAllowedException' with message 'Autoload path not allowed: /home/travis/build/owncloud/core/tests/lib/testcase.php' in /home/travis/build/owncloud/core/lib/autoloader.php:134
Stack trace:
#0 /home/travis/build/owncloud/core/lib/autoloader.php(154): OC\Autoloader->isValidPath('/home/travis/bu...')
#1 [internal function]: OC\Autoloader->load('Test\\TestCase')
#2 /home/travis/build/owncloud/core/apps/files_pdfviewer/tests/unit/controller/displaycontrollertest.php(19): spl_autoload_call('Test\\TestCase')
#3 phar:///home/travis/.phpenv/versions/5.5.21/bin/phpunit/phpunit/Util/Fileloader.php(58): include_once('/home/travis/bu...')
#4 phar:///home/travis/.phpenv/versions/5.5.21/bin/phpunit/phpunit/Util/Fileloader.php(42): PHPUnit_Util_Fileloader::load('/home/travis/bu...')
#5 phar:///home/travis/.phpenv/versions/5.5.21/bin/phpunit/phpunit/Framework/TestSuite.php(328): PHPUnit_Util_Fileloader::checkAndLoad('/home/travis/bu...')
#6 phar:///home/travis/.phpenv/versions/5.5.21/bin/phpu in /home/travis/build/owncloud/core/lib/autoloader.php on line 134

@Xenopathic 🙊

@RobinMcCorkell
Copy link
Member

@LukasReschke Please read the mailing list and/or the documentation: https://doc.owncloud.org/server/8.2/developer_manual/app/testing.html#php 😄

TL;DR: You need \OC::$loader->addValidRoot(\OC::$SERVERROOT . '/tests'); in your test bootstrap.

@LukasReschke
Copy link
Member Author

/me is too stupid 🙈

@volkswagner
Copy link

Thank you for this fix. Now all my pdf files are viewable in owncloud server. No more blank pdf files.
You guys rock!

LukasReschke added a commit that referenced this pull request Sep 18, 2015
@LukasReschke LukasReschke merged commit c871eaa into master Sep 18, 2015
@LukasReschke LukasReschke deleted the whitelist-all-image-domains branch September 18, 2015 19:37
@LukasReschke LukasReschke mentioned this pull request Sep 18, 2015
@niefra niefra mentioned this pull request Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants