Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize CI setup #165

Merged
merged 5 commits into from
Dec 19, 2018
Merged

Standardize CI setup #165

merged 5 commits into from
Dec 19, 2018

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Dec 12, 2018 •
edited
Loading

Standardize CI for owncloud/files_primary_s3.

Fixes #116.

  • Use make in drone

@skshetry skshetry self-assigned this Dec 12, 2018
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@skshetry skshetry force-pushed the standardize-ci branch 10 times, most recently from 3c4b802 to 35c0226 Compare December 13, 2018 11:32
@skshetry
Copy link
Member Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

phil-davis
phil-davis reviewed Dec 14, 2018
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. CI takes 3 hours! Let's see what it says. I will approve after that.

@skshetry
Copy link
Member Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@skshetry
Copy link
Member Author

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@skshetry skshetry force-pushed the standardize-ci branch 2 times, most recently from 35c0226 to 3a2c12e Compare December 18, 2018 08:45
@skshetry
Copy link
Member Author

skshetry commented Dec 18, 2018 •
edited
Loading

Currently, we have web UI tests split into 8 parts. But, even then, the tests run for 3-4 hours, due to which we are getting 'code integrity errors'. Thus, this doubles the
partitions for web UI which hopefully will remove the errors. API tests are happy for now, so I have left as it is for now.

P.S: Integrity errors appear after the tests have been running for 30-35 mins."

phil-davis
phil-davis reviewed Dec 18, 2018
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something not right in the drone + Makefile because each "part 1" is running the whole of the core tests, and "part 2" ... are running no tests.

@skshetry @phil-davis
Standardize CI setup
9b3cbb3
@skshetry @phil-davis
Split tests into multiple parts
f8c5402 
Currently, we have webui tests splitted into 8 parts. But, even then, the tests run for
3-4 hours, due to which we are getting 'code integrity errors'. Thus, this doubles the
partitions which hopefully will remove the errors.

P.S: Integrity errors appear after the tests has been running for 30-35 mins.
@phil-davis
Copy link
Contributor

Rebased and resolved conflict in .drone.yml

@phil-davis
Copy link
Contributor

phil-davis commented Dec 19, 2018 •
edited
Loading

@skshetry I added some commits last night while trying to see what the problem was. Those commits just make some labels a bit more standard in .drone.yml

The actual final fix was to core - PR owncloud/core#33929 - it was not finding the list of core test suites correctly unless the script first did a cd to the core tests/acceptance directory. I managed to fix that in core last night in time to get it into the QA tarball.

I just restarted the drone job again for this PR. Earlier this morning it had some unrelated "git fetch" errors.

I changed the status to "4 - To release". Let me know if if you have any other changes you were thinking to do!

@phil-davis phil-davis merged commit b8f7e19 into master Dec 19, 2018
@delete-merged-branch delete-merged-branch bot deleted the standardize-ci branch December 19, 2018 08:56
@patrickjahns patrickjahns mentioned this pull request Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@skshetry skshetry

Labels
4 - To release Drone QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skshetry @CLAassistant @ownclouders @phil-davis