-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coding standard #57
Conversation
|
32fbde9
to
22bedce
Compare
Fixes #55 |
@DeepDiver1975 can you fix the .drone.yml conflict ? |
22bedce
to
c6b006a
Compare
@@ -28,6 +28,14 @@ pipeline: | |||
db_host: ${DB_HOST} | |||
git_reference: ${CORE_BRANCH} | |||
|
|||
php-cs-fixer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs in every drone job.
Do we want to add:
when:
matrix:
TEST_SUITE: phpunit
so that at least it only runs in each of the phpunit
jobs?
I fixed the conflict, since @DeepDiver1975 is on leave. |
👍 |
c6b006a
to
25d4277
Compare
failing tests are unrelated -> merge |
No description provided.