Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package vendor/firebase/php-jwt #389

Merged
merged 2 commits into from Mar 27, 2023
Merged

package vendor/firebase/php-jwt #389

merged 2 commits into from Mar 27, 2023

Conversation

jnweiger
Copy link
Contributor

It does not seem safe to rely on vendor/firebase/php-jwt from files_external or elsewhere.
Seems we should package and use our own copy.

Fixes #388

…nal or elsewere.

We should package and use our own copy...
@jnweiger jnweiger requested review from mrow4a and pako81 March 25, 2023 21:38
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIActivity-master-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/files_texteditor/1989/14

@phil-davis phil-davis self-requested a review March 27, 2023 11:50
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pako81
Copy link
Contributor

pako81 commented Mar 27, 2023

merge?

@jnweiger jnweiger merged commit d737bd9 into master Mar 27, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the add-vendor branch March 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] dependency firebase/php-jwt is not packaged
4 participants