Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not break if mount is not avalable #739

Merged
merged 1 commit into from Mar 28, 2018
Merged

Do not break if mount is not avalable #739

merged 1 commit into from Mar 28, 2018

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Jan 15, 2018

Fixes: #735

Licence: MIT or AGPL

Description

This has also been fixed and merged in Gallery / Nextcloud PR 327

Check list

  • Code is properly documented
  • Code is properly formatted
  • Commits have been squashed
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

@PVince81 or @DeepDiver1975

PVince81
PVince81 approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense, thanks.

Did you test it ?

@mmattel
Copy link
Contributor Author

mmattel commented Feb 4, 2018

I can test if the upgraded SMB backend is merged.
Currently we have the "Anonymous" access problem...

PVince81
PVince81 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit d2399c7 into master Mar 28, 2018
@PVince81 PVince81 deleted the ignore-unavailable-storage branch March 28, 2018 07:47
@PVince81 PVince81 added this to the qa milestone Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.1.0
Development

Successfully merging this pull request may close these issues.

Gallery fails to start if one out of more mounts is inaccassible
2 participants
@mmattel @PVince81