fix: group admins can impersonate again #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
yes, confirmed to work (tested on 10.13.3). Additionally tested on 10.12.0 (previous core changes) and it also works there 👍 |
pako81
approved these changes
Dec 11, 2023
|
@jvillafanez merge it or another review needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: https://github.com/owncloud/enterprise/issues/6277
There have been some changes in core (around 10.13) to keep a different data structure for the group information in order to make it more flexible. Due to this change, some of the impersonation functionality wasn't working.
This PR fixes the problem and keeps backwards compatibility, so the app can keep the minimum OC version.