Cancel uploads

[jesmrec]

As user, i want to cancel a progressing upload, so that i can save time and bandwidth if i select incorrectly a file to upload

Option to cancel a pending/ongoing upload is a good choice if the user select a wrong file or simply decides to put off the upload. Actually, uploads can not be cancelled and user must wait till upload finishes to get rid of the file. In case the file is huge, time and bandwidth are wasted.

Taking advantage of the lack of three-dot-button in cells of uploading files, set here a cancel option in the same place is a good choice.

AC:

• In the list of files, the uploading file should display an option to cancel (activity involved?)
• If the user cancels, upload stops and file is removed from the bookmark.
• If the user cancels offline, upload process is dismissed and not resumed when user recovers connectivity

Operations done:

• Uploads
• Downloads

[felix-schwarz]

Yes, the SDK supports cancelling uploads by calling cancel on the NSProgress objects returned by the core. That cancel is passed along to the actual HTTP request in the background NSURLSession and cancels the upload. I'll have to check how the Sync Engine deals with that event, though.

[felix-schwarz]

As of 1a7f260 there's now some initial support for cancelling uploads inline as well as in the activity tab:

[jesmrec]

After implementation on #253, it is already implemented for uploads/downloads and pending for a possible future implementation on other operations. Removing from current milestone, waiting for be triaged again

[michaelstingl]

@jesmrec what are the remaining tasks?

[jesmrec]

with the latest implementation:

• Only uploads and downloads are allowed to be cancelled.
• Cancellable operations are allowed to be cancelled when they are on course. Enqueued operations can not be cancelled (check [feature/fp-series-4] File Provider improvements #253 (comment))