Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Swiping PDF thumbnail view on the iPhone #918

Closed
hosy opened this issue Mar 4, 2021 · 2 comments · Fixed by #920
Closed

[BUG] Swiping PDF thumbnail view on the iPhone #918

hosy opened this issue Mar 4, 2021 · 2 comments · Fixed by #920
Assignees
@hosy
Milestone
11.6.0

Comments

@hosy
Copy link
Collaborator

hosy commented Mar 4, 2021 •
edited

Swiping the PDF thumbnail view on the iPhone is not working very well (when position is on bottom).
In my opinion the PDF detail view will only open one item. This means the UIScrollView.isScrollEnabled can be disabled to solve this problem.

Steps to reproduce

  1. Open PDF in detail view on a iPhone
  2. Swipe throw the thumbnail view

Expected behavior

Thumbnail view will change PDF page to the selected thumbnail

Actual behavior

Overlaying page controller is trying to change the page on the enabled UIScrollView.

Client

iOS version:
iOS 14.4

ownCloud app version:
11.5.2

Device model:
iPhone

RPReplay_Final1614868421.mov
@hosy hosy added this to the 11.6.0-Current milestone Mar 4, 2021
@hosy hosy self-assigned this Mar 4, 2021
@michaelstingl
Copy link
Contributor

Ah. Good explanation. I also thought it feels a little bit rubbery, but I didn’t see the connection. 👍

hosy added a commit that referenced this issue Mar 5, 2021
@hosy
#918 automatically page scrolling in preview view
b1d5a98 
- disable page scrolling if less than two items inside the page view controller
- prevent page scrolling, when try to scroll inside the pdf thumbnail view on the iPhone
@hosy hosy mentioned this issue Mar 5, 2021
Merged
10 tasks
@jesmrec jesmrec linked a pull request Mar 8, 2021 that will close this issue
[fix/auto-page-scrolling] Auto Enable Page Scrolling in Detail View #920
Merged
10 tasks
@jesmrec
Copy link
Contributor

jesmrec commented Mar 15, 2021

Done! Ready to 11.6

@jesmrec jesmrec closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hosy hosy

Labels
None yet
Projects
None yet
Milestone
11.6.0
Development

Successfully merging a pull request may close this issue.

[fix/auto-page-scrolling] Auto Enable Page Scrolling in Detail View owncloud/ios-app
3 participants
@michaelstingl @hosy @jesmrec