[feature/oidc-dcr-fallback] Fallback on/ignore OIDC Dynamic Client Registration errors #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error
|
|
felix-schwarz
changed the title
felix-schwarz
changed the title
hosy
approved these changes
Dec 16, 2021
|
Tests done:
It's OK from my side. Approved |
jesmrec
approved these changes
Dec 16, 2021
hosy
added a commit
that referenced
this pull request
Dec 22, 2021
* preparing bug fix release 11.8.1 * - added in-app release notes - added fastlane changelog - added Calens changelog entry * Calens changelog updated * [feature/oidc-dcr-fallback] Fallback on/ignore OIDC Dynamic Client Registration errors (#1068) * - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error * - fix infinite OAuth2 token refresh loop via SDK update * removed ipa name to get a timestamp ipa output name * changed ipa name by value * output git branch, set git branch in IPA file name * remove newline from gitbranch name * set git branch in branding.plist * renamed git hash key * - new version number for upload - changed changelog folder name * Calens changelog updated * [fix/connection-stuck] Fix eternal "Connecting…" (#1080) * - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error * - fix infinite OAuth2 token refresh loop via SDK update * - BookmarkViewController: store user.displayName in .userDisplayName rather than .displayName - OCBookmark+AppExtensions: - make .displayName readonly and mark it as legacy - return .userDisplayName for .displayName if the former has a value - StaticLoginSingleAccountServerListViewController: - remove OCConnection code to fetch a user's display name and use bookmark.displayName instead - listen for bookmark updates and trigger a header update then accordingly - update SDK to gain bookmark.userDisplayName support * - update SDK to gain bookmark.userDisplayName support Co-authored-by: Matthias Hühne <mhuehne@owncloud.com> * new build number * use latest develop sdk commit * [fix/core-overlap] Fix OCCore overlap for first connection (#1081) * - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error * - fix infinite OAuth2 token refresh loop via SDK update * - BookmarkViewController: store user.displayName in .userDisplayName rather than .displayName - OCBookmark+AppExtensions: - make .displayName readonly and mark it as legacy - return .userDisplayName for .displayName if the former has a value - StaticLoginSingleAccountServerListViewController: - remove OCConnection code to fetch a user's display name and use bookmark.displayName instead - listen for bookmark updates and trigger a header update then accordingly - update SDK to gain bookmark.userDisplayName support * - update SDK to gain bookmark.userDisplayName support * Prevent unwanted connection following setup of the first account, preventing an immediate OCCore request and unclean return with possible instance overlap by starting the connection on the - at that time - already removed parent view controller. * new build number Co-authored-by: Matthias Hühne <mhuehne@owncloud.com> * - updated build number - updated release notes - changed changelog folder name * Calens changelog updated * - update SDK (#1064) - make SortMethod.comparator use OCSQLiteCollationLocalized.sortComparator * Configuration documentation updated * added improved sorting to changelog * new changelog entry * Calens changelog updated Co-authored-by: hosy <hosy@users.noreply.github.com> Co-authored-by: Felix Schwarz <fs-git@iospirit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
authentication-oauth2.oidc-fallback-on-client-registration-failure- defaulting totrue- to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error.In effect, all errors in OIDC DCR are ignored - and the client henceforth behaves as if OIDC DCR wasn't configured on the target server.
Related Issue
https://github.com/owncloud/enterprise/issues/4904
Types of changes