Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/image-interactions] VisionKit / text recognition actions for images #1283

Merged
merged 4 commits into from Dec 7, 2023

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Oct 6, 2023

Description

This PR adds VisonKit interactions to the image viewer, allowing to select and interact with recognized content (f.ex. text) like in the Photos app.

Based on #1274 for its Xcode 15 compatibility.

Reference:
https://developer.apple.com/documentation/visionkit/enabling_live_text_interactions_with_images?language=objc

Disabling Image Interactions is possible by setting action.allow-image-interactions to false.

Screenshots (if appropriate):

Simulator Screenshot - iPhone 15 Pro - 2023-10-06 at 10 52 27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@felix-schwarz felix-schwarz changed the base branch from master to feature/account-wizard October 6, 2023 09:01
@felix-schwarz felix-schwarz added this to the 12.1-Next milestone Oct 6, 2023
@jesmrec jesmrec added the Approved by QA Approved by QA label Dec 7, 2023
@hosy hosy merged commit e092190 into feature/account-wizard Dec 7, 2023
2 of 5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/image-interactions branch December 7, 2023 18:07
@jesmrec jesmrec mentioned this pull request Apr 24, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants