[fix/available-offline-policy-cleanup] Fix cleanup of Available Offline policies targeting unavailable spaces

[felix-schwarz]

Description

Fix an issue arising from Available Offline policies targeting unavailable/detached drives and removes the respective policies.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jesmrec]

Any way to reproduce the initial problem?

[felix-schwarz]

@jesmrec What should work:

1. Build and run a prior version (milestone/12.2 should do)
2. Add an ocis account with a space
3. Cut the internet connection (or stop the server) so the app no longer has a connection to the server
4. In the app mark a file in the space as "available offline"
5. On the server, delete the space
6. Bring the app or server back online

The app will then try to download the file, but keep re-scheduling the download even if the download failed or you cancelled it.

Switching to fix/available-offline-policy-cleanup then will fix that issue and the download will not be re-scheduled after it failed or has been cancelled.

[jesmrec]

thanks @felix-schwarz!

i've tried more cases in which a file is removed without connection at the time is downloaded/av. offline. This is not an easy one to reproduce because some randomness probably plays a role, so i noticed the error in a few executions over the milestone branch as i tried to reproduce, and no reproducible in fix branch.

Let's move forward if the CR passes and wait for valuable feedback.