Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Failed uploads, no retry option #545

Closed
enoch85 opened this issue Dec 26, 2015 · 10 comments
Closed

Failed uploads, no retry option #545

enoch85 opened this issue Dec 26, 2015 · 10 comments

Comments

@enoch85
Copy link
Member

enoch85 commented Dec 26, 2015

On my girlfriends iPhone 6 there are occasionally failed uploads, sometimes because of failed credentials (Why? The credentials are correct - maybe another bug?) and sometimes due to "File Error".

The File Error failure doesn't give the user another try to upload the pictures, and it doesn't say why the upload failed - is it because it's duplicated, lost connection, or something else?

So I would like two things;

  • More verbose output of why the upload failed.
  • A retry option so that you can manually retry to upload the failed file - and if the file exists then overwrite the old one to be sure that it's uploaded. The overwrite part could be an option.

Linking the Android issue here: owncloud/android#340

@nasli nasli added the Bug label Dec 30, 2015
@nasli nasli added this to the 3.4.7-current milestone Dec 30, 2015
@nasli
Copy link
Contributor

nasli commented Dec 30, 2015

Hello @enoch85, thanks for reported it.
Could be related with a keychain issue fixed, we will review it.

@rperezb
Copy link

rperezb commented Jan 28, 2016

Hey @enoch85 thanks for reporting this, it's expected to be fixed within next version: #560
It it weren't please, reopen the issue

About the retry option, how the app is designed:

  • Those uploads that failed due to network/server connection, they are retried automatically
  • Those uploads that needs user interaction, they are not retried, such as: permisions error,...login credentials.

In this concrete situation, it was a login credentials error

@enoch85
Copy link
Member Author

enoch85 commented Jan 28, 2016

Thanks for the fix guys!

@enoch85
Copy link
Member Author

enoch85 commented Mar 26, 2016

Failed uploads due to "credentials error" (even if the credentials are correct) still occurs.

@enoch85 enoch85 reopened this Mar 26, 2016
@enoch85 enoch85 modified the milestones: 3.4.9-current, 3.4.8-current Mar 26, 2016
@javiergonzper
Copy link
Contributor

This could be related with access to the keychain.
@enoch85 I am not sure if we will check it before 3.4.9... maybe the right milestone it is "backlog".

cc: @rperezb

@rperezb
Copy link

rperezb commented Mar 29, 2016

@enoch85 we'd need to know first of all, how to reproduce this error. From our end, it's working just fine.

As @javiergonzper has said, it's better to move it to the backlog, at least, we need to be able to reproduce to fix it.

@rperezb rperezb modified the milestones: backlog, 3.4.9-current Mar 29, 2016
@enoch85
Copy link
Member Author

enoch85 commented Mar 29, 2016

@rperezb Sorry, I should know better. :)

I just checked the failed uploads a few days ago and saw that the same error as I reported in the first post. Have not been able to reproduce it as I have to travel 500 meters for each photo taken. ;)

@rperezb
Copy link

rperezb commented Mar 29, 2016

@enoch85 there is another trick, kill the app and open it again, it should enforce the instant uploads or switch the device to airplane mode

@enoch85
Copy link
Member Author

enoch85 commented Mar 29, 2016

@rperezb Ok, thanks! Will try when I get some time over, thursday maybe.

@enoch85
Copy link
Member Author

enoch85 commented Apr 5, 2016

Opened a new issue here instead with fresh details: #622

Haven't seen the credentials error lately.

@enoch85 enoch85 closed this as completed Apr 5, 2016
@davivel davivel removed this from the backlog milestone Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants