Instant upload #666
Instant upload #666
Conversation
Setted the text color of the navigation bar on the share cells
Fixed a problem on the branding colors of the buttons on the share view
… new view to enter the text
…th to use generic ones. Move temp file to local path after the upload finished
…ffline system for new files
[Doc] user manual updates for 3.4.9 release
Add new txt documents
|
User of the commit 9d503e3 is unknown - cannot determine CLA |
| // Get the old instant upload date so it can be migrated to an NSTimestamp | ||
| __block long lastDateInstantUpload; | ||
| [queue inDatabase:^(FMDatabase *db) { | ||
| FMResultSet *rs = [db executeQuery:@"SELECT date_instant_upload FROM users WHERE activeaccount=1"]; |
There was a problem hiding this comment.
We could get also here if the instant upload was active to avoid the previous access to the DB
There was a problem hiding this comment.
@nasli Direct DB querying is necessary here because the migrations take place before the current user is initialize.
There was a problem hiding this comment.
I mean, use this query adding the instant_upload column
[db executeQuery:@"SELECT date_instant_upload, instant_upload FROM users WHERE activeaccount=1"];
to avoid this line:
BOOL defaultBackgroundInstantUploadValue = (BOOL)[ManageAppSettingsDB isInstantUpload];
that is doing another query to the same table.
|
@Jon-Schneider can you please add the email address of your first commit to your github profile? Otherwise the commit cannot be identified as yours - THX |
|
@DeepDiver1975 Done. |
THX |
|
There are conflicts with this branch, please rebase it @Jon-Schneider |
| if ([PHPhotoLibrary authorizationStatus] == PHAuthorizationStatusAuthorized) { | ||
| ACTIVE_USER.instantUpload = YES; | ||
| [ManageAppSettingsDB updateInstantUploadTo:YES]; | ||
| [self attemptUpload]; |
There was a problem hiding this comment.
You should init here timestampInstantUpload in DB and activeUserDto with the current date, as you did with instantUpload.
There was a problem hiding this comment.
So that images taken before instant upload is enabled aren't uploaded? I believe the behavior of Dropbox and similar apps (Google Photos) is to upload your entire history, but I'm not sure what OwnCloud has done in the past.
There was a problem hiding this comment.
Yes, that is how Owncloud works, only upload new photos taken, that it is the meaning of instant uploads.
Upload all the images of the camera should be a new and different feature.
… are not favorites or son of favorites
… background upload preference has now been seperated from the InstantUpload preference. Instant Upload now uses the Photos Library instead of the Assets library for photo access."
…Request Review Feedback.
…nagement from PrepareFilesToUpload to InstantUpload. Instant upload last uploaded timestamp is now stored as an NSTimeInterval rather than a long. Migrates the storage of last instant upload from long to NSTimeInterval in both storage and on User objects.
|
I just destroyed my branch with an accidental rebase off master. I'm going to quickly reimplement and re-pull. |
|
Reimplemented in Pull Request #681 |
This Pull Request Does the Following:
NEEDS:
Translations:
Possible Needs:
TASKS