Feature/karma #113
Feature/karma #113
Conversation
DeepDiver1975
force-pushed
the
feature/karma
branch
from
9d2ddf9
to
2e45bdc
Compare
DeepDiver1975
force-pushed
the
feature/karma
branch
from
ee19c25
to
3638c5c
Compare
DeepDiver1975
force-pushed
the
feature/karma
branch
from
3638c5c
to
4149621
Compare
| // test results reporter to use | ||
| // possible values: 'dots', 'progress' | ||
| // available reporters: https://npmjs.org/browse/keyword/karma-reporter | ||
| reporters: ['dots'], |
There was a problem hiding this comment.
later on you can enable code coverage output here
tests/appsTest.js
Outdated
|
|
||
| describe("Currently testing apps management,", function() { | ||
| // CURRENT TIME | ||
| var timeRightNow = new Date().getTime(); |
There was a problem hiding this comment.
if you import the "sinon" JS library, you can also use fake timers to reduce randomness of time-related tests
tests/appsTest.js
Outdated
| // there are cors issues with this api | ||
| describe("App attributes testing,", function() { | ||
| beforeEach(function(done) { | ||
| var key = ['attr1', 'attr+plus space', '属性1']; |
tests/sharingTest.js
Outdated
| /* globals ownCloud, __karma__ */ | ||
|
|
||
| // CURRENT TIME | ||
| var timeRightNow = new Date().getTime(); |
There was a problem hiding this comment.
I suggest moving all those vars into the first describe() block. There's a risk that these will conflict with the values from other files if loaded in sequence.
There was a problem hiding this comment.
in this case I need to duplicate all these vars into two describe blocks - right?
There was a problem hiding this comment.
oh, I didn't noticed that. Then wrap the whole file in another describe() block then that describes the whole file...
|
remaining todos will come in followup prs ->merge |
Description
Move testing over to karma and test in browser.
ToDo - maybe followup PRs