This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Gomez and @jancborchardt to be potential reviewers |
@owncloud/mail @Mar1u5 @MorrisJobke |
ChristophWurst
force-pushed
the
search-rework
branch
from
August 4, 2016 13:47
8e08aa9
to
3b360e8
Compare
As said, please use the .emptycontent class and styles. :) Then it will also make the text greyish like everywhere else. If alignment is not perfect, please fix it in apps.css instead of here. ;) |
done |
All nice except for one issue: When the »Searching for …« view is shown, there’s an unnecessary scrollbar. |
@jancborchardt should be fixed now, if not – fix it ;-) |
Very nice! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re(thought|worked|factored) the client-side search code and UX a bit and introduced the following enhancements: