Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Search rework #1609

Merged
merged 7 commits into from
Aug 5, 2016
Merged

Search rework #1609

merged 7 commits into from
Aug 5, 2016

Conversation

ChristophWurst
Copy link
Contributor

I re(thought|worked|factored) the client-side search code and UX a bit and introduced the following enhancements:

  • show loading view on content instead of the old message list of the previously selected folder as the messages will probably disappear while searching anyway
  • searching shows immediate feedback (still debouncing the actual server request though)
  • search is done on an route of its own, hence the page can be refreshed
  • show emtpy-config view and no-search-result view automatically (let Marionette handle it)

@mention-bot
Copy link

@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Gomez and @jancborchardt to be potential reviewers

@ChristophWurst
Copy link
Contributor Author

@owncloud/mail @Mar1u5 @MorrisJobke

@jancborchardt
Copy link
Contributor

As said, please use the .emptycontent class and styles. :) Then it will also make the text greyish like everywhere else.

If alignment is not perfect, please fix it in apps.css instead of here. ;)

@ChristophWurst
Copy link
Contributor Author

done

@jancborchardt
Copy link
Contributor

All nice except for one issue: When the »Searching for …« view is shown, there’s an unnecessary scrollbar.

@ChristophWurst
Copy link
Contributor Author

@jancborchardt should be fixed now, if not – fix it ;-)

@jancborchardt
Copy link
Contributor

Very nice! 👍

@jancborchardt jancborchardt merged commit afb70cf into master Aug 5, 2016
@jancborchardt jancborchardt deleted the search-rework branch August 5, 2016 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants