Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename folder sends "MKCOL" and "DELETE" request instead of "MOVE" #107

Closed
schiessle opened this issue Nov 23, 2012 · 7 comments
Closed
Labels

Comments

@schiessle
Copy link

If I rename a folder within my sync folder the client calls "MKCOL" for the new name and "DELETE" for the old name. This leads to problems with shared folders because the delete operation also removes all share connections for the folder and obviously it is not possible to recognize this two operations as one rename operation on the server side.

In contrast renaming a file preserves the share connections because for files the client sends a "MOVE" request.

See also issue: owncloud/core#422

@dragotin
Copy link
Contributor

This is a tough problem. It is not easy to actually detect a move on client side. The client actually does a move detection, but that is only working if a proper client database is existing. If not, there is no chance for the client to detect moves. Not much we can do about that.

I think if a file or directory gets renamed within a synced folder, the file should inherit the settings from the parent folder. And if a folder gets renamed that is the "top" folder for the sharing, I think it's fair to not inherit sharing.

@allo-
Copy link

allo- commented Jan 26, 2013

maybe you want to have a look at http://en.wikipedia.org/wiki/Inotify

@RandolfCarter
Copy link

maybe you want to have a look at http://en.wikipedia.org/wiki/Inotify

Should be in client 1.2.0 - was it used for rename detection as well?

@Deltachaos
Copy link

This is important!

@dphi
Copy link

dphi commented Apr 11, 2013

Renaming folders containing data takes a too long time too..

For each folder within the renamed folder, a MKCOL and DELETE is being issued. Then, every file is moved individually with MOVE, PROPPATCH, PROPFIND. These three commands take on my otherwise idle system about 8s per file!

@guruz
Copy link
Contributor

guruz commented May 7, 2013

There is code for rename handling in http://git.csync.org/users/ogoffart/csync.git/log/?h=rename_folders
However it was not merged into the normal csync yet.

@danimo
Copy link
Contributor

danimo commented Jun 12, 2013

Fixed in 1.3.0. Check out beta3 to test it.

@danimo danimo closed this as completed Jun 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants