Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampache error due to interface mismatch #1138

Closed
boynux opened this issue Mar 29, 2024 · 3 comments
Closed

Ampache error due to interface mismatch #1138

boynux opened this issue Mar 29, 2024 · 3 comments
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Bug

Comments

@boynux
Copy link

boynux commented Mar 29, 2024

Hi

I tried to use Ampache API on a self hosted owncloud, however, I'm getting the following error:

PHP Fatal error: Declaration of OCA\\Music\\Controller\\AmpacheController_AllTracksPlaylist::__construct(string $userId, OCA\\Music\\BusinessLayer\\TrackBusinessLayer $trackBusinessLayer, OCP\\IL10N $l10n) must be compatible with OCP\\AppFramework\\Db\\EntityInterface::__construct() in /mnt/data/apps/music/lib/Controller/AmpacheController.php on line 2179

Thank you!
@boynux
Copy link
Author

boynux commented Mar 29, 2024

This commit owncloud/core@825364e seems to be the culprit

@paulijar paulijar added the Bug label Mar 30, 2024
@paulijar
Copy link
Collaborator

Thanks for the report. So apparently classes inheriting the Entity class from the framework are no longer allowed define a constructor taking any arguments. I guess I need to refactor my code a bit.

paulijar added a commit that referenced this issue Apr 8, 2024
@paulijar
Fix Ampache API not working on ownCloud 10.14.0
81d0515 
The ownCloud version 10.14.0 has changed the Entity base class and any
classes (indirectly) inheriting it are no longer allowed to have a
constructor taking arguments. Hence, we need to construct our "All
Tracks adapter" playlist in the Ampache API a bit differently.

refs #1138
@paulijar paulijar added the 6 - Ready for release Fix or feature is ready and will be included in the next release label Apr 8, 2024
@paulijar
Copy link
Collaborator

This is now fixed in Music v1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boynux @paulijar