removed white background color from controls as this makes it almost … #1002
Conversation
…impossible to see the controls and the artist/album name
|
We can't make it like that because then the app would look like this on NC25 with the default theme: I guess you are using some 3rd party theme, which one? Maybe the fix should go to the theme. Or then we need to figure out a more intelligent way to do this. Does the color of the control pane work nicely on that theme if you declare |
|
Ok I see your point, the theme is breeze dark https://github.com/mwalbeck/nextcloud-breeze-dark. Setting |
That's because ownCloud doesn't declare those color properties, that's a Nextcloud-specific thing. However, I just learned that the css |
When we use the common color constants, we don't need to define as many exceptions for the built-in dark theme of Nextcloud. Similarly, 3rd party themes will have easier time as every element doesn't need its own custom rule. Note that the used color constant `color-main-background-translucent` is not available on any version of ownCloud. To mitigate this, the hard-coded translucent white color is used as a fallback color. refs #1002
|
I now committed a change like described above. In addition to the controls pane, I applied it on the background of the "scanning"/"no content available" banner as well as on the "embedded player" used within the Files app. The Breeze Dark theme already seemed to have an overriding rule for the embedded player background which is why no problem was seen there. But for the "scanning" banner, it uses the Music app's color definition. |
|
perfect, thank you kindly :) |
|
The fix has been now released in Music v1.7.0. |
removed the white background color from the control as this makes it impossible to see the controls and the artist/album name see below:
