Ampache: also accept authentication in "ssid" key #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, we only accepted the authentication token in the "auth" key. This is the same as in Ampache. However, for the URL of a song, Ampache passes the authentication token in the "ssid" key. Some clients expect this key to have this name, for example the Ampache Plugin for Rhythmbox, as shipped with Ubuntu. After this change, Rhythmbox works fine. There is also a client-side fix for this problem: <lotan/rhythmbox-ampache@0d233e3>
|
Okay, makes sense. Please follow the project style guide and indent with tabs instead of spaces. |
|
@youknow0 I can merge this PR once you fix the indentations. |
|
Sorry, I am a little busy right now. Indents should be fixed now. |
|
The inspection completed: 1 updated code elements |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we only accepted the authentication token in the "auth"
key. This is the same as in Ampache.
However, for the URL of a song, Ampache passes the authentication
token in the "ssid" key. Some clients expect this key to have
this name, for example the Ampache Plugin for Rhythmbox, as shipped
with Ubuntu.
After this change, Rhythmbox works fine.
There is also a client-side fix for this problem:
lotan/rhythmbox-ampache@0d233e3