Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST base url #217

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Fix REST base url #217

merged 1 commit into from
Apr 5, 2016

Conversation

Henni
Copy link
Contributor

@Henni Henni commented Apr 4, 2016

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @LukasReschke, @BernhardPosselt and @owncloud-news-gitter-bot to be potential reviewers

@DatGizmo
Copy link

DatGizmo commented Apr 4, 2016

@Henni: Works
Notes are shown now. :)

@Lepelaar
Copy link

Lepelaar commented Apr 4, 2016

Yep! seems to work for me too! :-)

I tested adding/deleting/updating notes, via web, android-app (MyOwnNotes) and desktop (windows) app (QOwnNotes). All working fine.

Thanx @Henni for the fast action :-)

@mikelupe
Copy link

mikelupe commented Apr 4, 2016

Thanks for the speed @Henni - notes appeared :)

edit: how the heck do I remove the smiley I placed for myself...¦°°¦#°¬

@ppmt
Copy link

ppmt commented Apr 4, 2016

I installed version 2.0.1 of Notes and it am still not able to create a new note from the web interface when mod_security is enabled

@mikelupe
Copy link

mikelupe commented Apr 4, 2016

@ppmt you have to edit the three files manually in the owncloud/apps directory, I guess there will be a 2.0.2 version in near future that contains those changes.

@ppmt
Copy link

ppmt commented Apr 4, 2016

My files are already like that. I should have said that I installed the branched fix-url rather than just 2.0.1

@mikelupe
Copy link

mikelupe commented Apr 4, 2016

@ppmt sorry, I misunderstood, my bad. I additionally restarted apache, just to be sure there was no caching involved... we never know.

@Henni
Copy link
Contributor Author

Henni commented Apr 5, 2016

In conclusion this seems to fix a 404 some users (including me) get.
But it doesn't fix the 403 mentioned by @ppmt and @Paviluf in #205.

@Henni Henni merged commit 4f6373f into master Apr 5, 2016
@Henni Henni deleted the fix-url branch April 5, 2016 08:19
@susca
Copy link

susca commented Apr 7, 2016

Thank you @Henni. Fixed it for me (OC 9.0.1 beta(stable), mod_security not installed)!

@lemmy04
Copy link

lemmy04 commented May 10, 2016

I am running OC 9.0.2 and still no fix for this.

@samweisgamdschie
Copy link

samweisgamdschie commented May 17, 2016

hello! what can i do to get this fix? i tried the version from today with git clone but it does not solve the 404 problem for me. I am running 8.1.1 (actually can't upgrade...).

Also do I have to pull another version than master? because owncloud tells me, that notes app (this git pulled version from today) has the version 2.0.0 ...?

EDIT: I recently found the patch in the git repo but sadly it does not work for me. In fact every version of notes app now has this issue! do you have any idea?

@samweisgamdschie
Copy link

I tried the master version today but without success. After a while debugging I found out that the problem was lying on the assets. I use the option
'asset-pipeline.enabled' => true,
in my config.php
So I had to remove /var/www/owncloud/assets directory as it is autogenerated. After this the assets where regenerated and the notes app is working again.

So many thanks for this app again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants