Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon doesnt update when notification appears while page is open #60

Closed
tomneedham opened this issue Feb 4, 2016 · 6 comments · Fixed by #63
Closed

Icon doesnt update when notification appears while page is open #60

tomneedham opened this issue Feb 4, 2016 · 6 comments · Fixed by #63
Assignees
Milestone

Comments

@tomneedham
Copy link
Member

Also the div#emptycontent is still present which looks strange
screen shot 2016-02-04 at 16 22 41

@tomneedham
Copy link
Member Author

Only happens in safari for some reason.

@nickvergessen
Copy link
Contributor

@tomneedham any chance you can fix this at some point?

@tomneedham
Copy link
Member Author

Yeah will do, just stuck it here so I dont forget.

@tomneedham tomneedham self-assigned this Feb 5, 2016
@nickvergessen nickvergessen added this to the 9.0-current milestone Feb 5, 2016
@nickvergessen
Copy link
Contributor

Have this as well, it happens when there have not been notifications initially but on polling there are some

@nickvergessen
Copy link
Contributor

btw for lazy testing add:

        return new \OC_OCS_Result([]);
        return new \OC_OCS_Result(json_decode('[{"notification_id":1,"app":"files_sharing","user":"admin","datetime":"2016-02-10T09:36:33+00:00","object_type":"remote_share","object_id":"1","subject":"You received \"\/test\" as a remote share from test1@localhost\/ownCloud\/master\/core","message":"","link":"","actions":[{"label":"Decline","link":"http:\/\/localhost\/ownCloud\/master\/core\/ocs\/v1.php\/apps\/files_sharing\/api\/v1\/remote_shares\/pending\/1","type":"DELETE","primary":false},{"label":"Accept","link":"http:\/\/localhost\/ownCloud\/master\/core\/ocs\/v1.php\/apps\/files_sharing\/api\/v1\/remote_shares\/pending\/1","type":"POST","primary":true}]}]', true));

as first line in

public function listNotifications() {

@tomneedham
Copy link
Member Author

Ah ideal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants