Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added role_quotas #159

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Added role_quotas #159

merged 7 commits into from
Mar 29, 2023

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Mar 21, 2023

Description

Added role_quotas to configuration YAML of proxy service.

Related Issue

Motivation and Context

Feature request

How Has This Been Tested?

Tested with helm template and the following own values YAML:

services:
  proxy:
    role_quotas:
      d7beeea8-8ff4-406b-8fb6-ab2dd81e6b11: 2000000000
      71881883-1768-46bd-a24d-a356a2afdf7f: 100000000000
      2aadd357-682c-406b-8874-293091995fdd: 100000000000

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@d7oc d7oc requested a review from wkloucek March 21, 2023 17:24
@d7oc d7oc added the Status:Needs-Review Needs review from a maintainer label Mar 21, 2023
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting role quotas work fine, please see comments

charts/ocis/values.yaml Outdated Show resolved Hide resolved
charts/ocis/values.yaml Outdated Show resolved Hide resolved
@@ -231,6 +231,21 @@ features:
filter:
# -- The object class to use for groups in the default group search filter like `groupOfNames`.
objectClass: groupOfNames
# -- Define quota settings.
quotas:
# -- Sets the maximum quota for spaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an example and possible units if applicable (GB, GiB, ..)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in latest commit. Would also be great if we could add a deep link to the existing Dokumentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable / deep links are not possible yet (as far as I know)

@@ -231,6 +231,21 @@ features:
filter:
# -- The object class to use for groups in the default group search filter like `groupOfNames`.
objectClass: groupOfNames
# -- Define quota settings.
quotas:
# -- Sets the maximum quota for spaces
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in latest commit. Would also be great if we could add a deep link to the existing Dokumentation.

charts/ocis/values.yaml Show resolved Hide resolved
@wkloucek wkloucek merged commit eb00672 into master Mar 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the d7_issue_150 branch March 29, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add configuration for role quotas
2 participants