-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added role_quotas #159
Added role_quotas #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting role quotas work fine, please see comments
- added max and default quota definitons
charts/ocis/values.yaml
Outdated
@@ -231,6 +231,21 @@ features: | |||
filter: | |||
# -- The object class to use for groups in the default group search filter like `groupOfNames`. | |||
objectClass: groupOfNames | |||
# -- Define quota settings. | |||
quotas: | |||
# -- Sets the maximum quota for spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an example and possible units if applicable (GB, GiB, ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in latest commit. Would also be great if we could add a deep link to the existing Dokumentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stable / deep links are not possible yet (as far as I know)
charts/ocis/values.yaml
Outdated
@@ -231,6 +231,21 @@ features: | |||
filter: | |||
# -- The object class to use for groups in the default group search filter like `groupOfNames`. | |||
objectClass: groupOfNames | |||
# -- Define quota settings. | |||
quotas: | |||
# -- Sets the maximum quota for spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in latest commit. Would also be great if we could add a deep link to the existing Dokumentation.
Description
Added
role_quotas
to configuration YAML of proxy service.Related Issue
Motivation and Context
Feature request
How Has This Been Tested?
Tested with
helm template
and the following own values YAML:Types of changes
Checklist:
make docs
) and committed