Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to natsjs registry #427

Merged
merged 4 commits into from
Nov 30, 2023
Merged

switch to natsjs registry #427

merged 4 commits into from
Nov 30, 2023

Conversation

wkloucek
Copy link
Contributor

Description

update oCIS to latest master and switch to natsjs registry

Related Issue

Motivation and Context

How Has This Been Tested?

  • run the nats deployment example in minikube

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek
Copy link
Contributor Author

@kobergj while implementing this I noticed, that store and cache support nats-js while registry now supports a natsjs option. Probably those options should have the same name for the oCIS 5 release, right?

@kobergj
Copy link
Contributor

kobergj commented Nov 20, 2023

Yes I saw that too when I was poking around in the helmchart. Let's unify them. Which one should we use? nats-js or natsjs?

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@wkloucek
Copy link
Contributor Author

Yes I saw that too when I was poking around in the helmchart. Let's unify them. Which one should we use? nats-js or natsjs?

The majority so far uses nats-js (store + cache). Changing them would be a breaking change?

@wkloucek wkloucek merged commit c11907b into next Nov 30, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the natsjs-registry branch November 30, 2023 14:54
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants