Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt streams to oCIS 5 #472

Merged
merged 2 commits into from
Jan 26, 2024
Merged

adapt streams to oCIS 5 #472

merged 2 commits into from
Jan 26, 2024

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 26, 2024

Description

see also owncloud/ocis#7272 (comment)

tested stream config with:

--- a/deployments/ocis-nats/helmfile.yaml
+++ b/deployments/ocis-nats/helmfile.yaml
@@ -73,6 +73,9 @@ releases:
     namespace: ocis
     chart: ../../charts/ocis
     values:
+      - image:
+          tag: latest
+          sha: 64ad9e99a4edc368f3702b44e6da51175b65d50e31133d02ccb4e551c0e4f49a
       - externalDomain: ocis.kube.owncloud.test

Related Issue

Motivation and Context

Update NACK to reflect streams used by oCIS 5 when using registry / cache / store on NATS

How Has This Been Tested?

  • run the ocis-nats example with the above patch

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek requested review from d7oc and kobergj January 26, 2024 11:03
@wkloucek
Copy link
Contributor Author

@kobergj I fixed the duplicate window for the registry because it again was bigger than the maxAge.... Just so that you don't run into the same error 😉 see also 4fcf017

@wkloucek wkloucek merged commit 401a5f5 into next Jan 26, 2024
1 check passed
@wkloucek wkloucek deleted the nack-stream-adaptions-ocis-5 branch January 26, 2024 12:10
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants