Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation about s3 bucket policy #98

Merged
merged 4 commits into from
Nov 7, 2022
Merged

add documentation about s3 bucket policy #98

merged 4 commits into from
Nov 7, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 7, 2022 •
edited

Description

document the s3 bucket iam policy for the s3ng storage driver

Related Issue

Motivation and Context

How Has This Been Tested?

  • on minio

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised: S3ng documentation docs-ocis#288
  • Documentation PR created:

@wkloucek wkloucek requested a review from mmattel October 27, 2022 08:18
mmattel
mmattel approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only judge on the outcome of the files necessary for docs-ocis which looks fine to me.

@wkloucek wkloucek mentioned this pull request Nov 7, 2022
Closed
@wkloucek wkloucek merged commit 434c507 into master Nov 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-s3-bucket-policy-doc branch November 7, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkloucek @mmattel