Introduced rollup for bundling UI #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
reviewed
Jan 10, 2020
LukasHirt
force-pushed
the
feature/switch-to-rollup
branch
4 times, most recently
from
4c3b6f4
to
35e466e
Compare
Fixed wrong name and removed description Brought back babel plugins Removed commit hook Brought back runtime transform Enabled runtime helpers
LukasHirt
force-pushed
the
feature/switch-to-rollup
branch
from
35e466e
to
0d17097
Compare
|
@tboerger Something we can do about the codacy review? The block it complains about has to be there since terser module hasn't got a default export. |
tboerger
approved these changes
Jan 13, 2020
|
What about reporting that bad behavior upstream? |
I've opened an issue there. codacy/codacy-jshint#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced rollup, optimised babel, removed vuex dependency and introduced how to interact with store by accessing it directly from Phoenix core.
Motivation
Rollup is optimised to build a bundle with as less code as possible thanks to the dead code elimination. In comparison with webpack we are losing its strong code splitting. Therefore for bigger extensions would be better to still use webpack. Example with webpack will come in follow up PR.