Range Header is not obeyed when downloading a file

[individual-it]

found when starting to run API tests with OCIS

try to download only a range of a file, e.g.: curl http://localhost:9140/remote.php/webdav/home/welcome.txt -u einstein:relativity -H "Range: bytes=51-77"

Expected behaviour:

only a range of the file should be downloaded

Actual behaviour:

the complete file is downloaded

[PVince81]

First naive attempt here: cs3org/reva#701

[PVince81]

• add storage capability for range requests
• expose "Accept-Range" header on Webdav HEAD call if the storage supports it
• extend storage interface to have range requests as current Download method doesn't have a way https://github.com/cs3org/reva/blob/master/pkg/storage/storage.go#L41
• extend dataprovider to pass in the range request to the storage
• react on "Range" header in Webdav GET call
• CS3 API extension for range requests ??

@butonic FYI

[PVince81]

another alternative approach would be calling Download and then seeking forward, but I'm not sure at which level this would still result in the whole stream being passed over the network between the storage and the seeker

[butonic]

tracked in reva as cs3org/reva#1395

[phil-davis]

Note: we added tests in owncloud/core#38247 to check various combinations of range request.
In the RFC it is acceptable for a server to reply to a range request with either status 206 and the range(s) requested (e.g. a multi-part range request) or to reply with status 200 and send the whole file. For example, if the server does not even support range requests it is free to "ignore" the requested ranges and just deliver the whole file. Also the server is free to decide its own "optimization" of the reply - for example, if the request is for a part of a small file then the server can choose to just send the whole file, rather than "bother" to send just the exact requested range.

We made the tests cope with that allowed variation.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.