Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review issues listed in expected to fail file #2078

Closed
individual-it opened this issue May 26, 2021 · 6 comments · Fixed by #2233
Closed

review issues listed in expected to fail file #2078

individual-it opened this issue May 26, 2021 · 6 comments · Fixed by #2233
Assignees
@dpakach @jasson99
Labels
QA:team

Comments

@individual-it
Copy link
Member

issues that are closed should not be in the expected to fails files. Ether the bug was not really fixed or (more likely) the test fails because of some other issue but the expected to fail file was not updated correctly

e.g. #1346 is closed but some tests are still marked with that issue in the expected to fail file
and the test Creating a new public link share of a file with password using the old public WebDAV API does not fail because of the range issue but because of lack of the "old webdav API missing for public links"
@jasson99 jasson99 self-assigned this Jun 2, 2021
This was referenced Jun 3, 2021
Merged
Merged
@jasson99
Copy link
Contributor

jasson99 commented Jun 4, 2021 •
edited by dpakach
Loading

The following issues in expected failures acceptance/expected-failures-API-on-OWNCLOUD-storage.md file are closed. Need to investigate and tagged the scenarios with correct issues.

@jasson99
Copy link
Contributor

jasson99 commented Jun 8, 2021 •
edited by dpakach
Loading

The following issues in expected failures acceptance/expected-failures-API-on-OWNCLOUD-storage.md file are closed. Need to investigate and tagged the scenarios with correct issues.

@jasson99 jasson99 mentioned this issue Jun 8, 2021
Merged
9 tasks
@jasson99
Copy link
Contributor

jasson99 commented Jun 8, 2021 •
edited
Loading

In acceptance/expected-failures-API-on-OCIS-storage.md the following closed issues are present along with respective scenarios:

This was referenced Jun 9, 2021
Merged
Merged
Merged
@dpakach dpakach self-assigned this Jun 11, 2021
@jasson99 jasson99 mentioned this issue Jun 11, 2021
Merged
9 tasks
@dpakach dpakach mentioned this issue Jun 14, 2021
Merged
11 tasks
@jasson99 jasson99 mentioned this issue Jun 14, 2021
Merged
9 tasks
@dpakach dpakach mentioned this issue Jun 15, 2021
Merged
9 tasks
@jasson99 jasson99 mentioned this issue Jun 15, 2021
Merged
11 tasks
@jasson99
Copy link
Contributor

jasson99 commented Jun 16, 2021 •
edited
Loading

The following closed issues in ocis-reva acceptance/expected-failures-on-OWNCLOUD-storage.md:

@jasson99
Copy link
Contributor

jasson99 commented Jun 16, 2021 •
edited
Loading

IN OCIS-REVA owncloud-storage

@phil-davis
Copy link
Contributor

Also see issue #2190 - the stale bot has been closing lots of issues.

If an issue still has a genuine failure in an expected-failures file, then we need to re-open the issue and add the "bug" or "Type:Technical-Debt" label. That will stop the "stale" bot from closing it.

@phil-davis phil-davis mentioned this issue Jun 18, 2021
Closed
This was referenced Jun 18, 2021
Merged
Merged
Merged
@jasson99 jasson99 mentioned this issue Jun 30, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpakach dpakach

@jasson99 jasson99

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tests-Only] Adjust expected failures for remaining closed issues owncloud/ocis
4 participants
@phil-davis @individual-it @dpakach @jasson99