Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating graph users using ocs endpoint crashes the ocis service #3483

Closed
kiranparajuli589 opened this issue Apr 7, 2022 · 1 comment · Fixed by #3530
Closed

updating graph users using ocs endpoint crashes the ocis service #3483

kiranparajuli589 opened this issue Apr 7, 2022 · 1 comment · Fixed by #3530
Assignees
@rhafer

Comments

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Apr 7, 2022 •
edited

Step to reproduce

  • create user brand-new-user using the graph API
  • try to update the same user using the OCS API
curl -kv -XPUT -uadmin:admin https://localhost:9200/ocs/v1.php/cloud/users/brand-new-user

Expected

Should show some error message

Actual

request exits with an empty response and the server is crashed with log:

{"level":"fatal","service":"ocs","time":"2022-04-06T16:41:19+05:45","message":"cs3 backend doesn't support editing users"}

Originally posted by @kiranparajuli589 in #3167 (comment)
This was referenced Apr 7, 2022
Closed
Merged
@kiranparajuli589
Copy link
Contributor Author

Tests which crashes ocis service due to this issue are now skipped with skipOnGraph.

After this issue is fixed:

  • follow up on skipped test scenarios, unskip them and run on ci

@rhafer rhafer self-assigned this Apr 12, 2022
rhafer added a commit to rhafer/ocis that referenced this issue Apr 13, 2022
@rhafer
return proper errors when ocs/cloud/users is using the cs3 backend
87b6ab1 
The ocs API was just exiting with a fatal error on any update request,
when configured for the cs3 backend. Now it returns a proper error.

Closes: owncloud#3483
@rhafer rhafer mentioned this issue Apr 13, 2022
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Apr 20, 2022
@rhafer
return proper errors when ocs/cloud/users is using the cs3 backend
fe53043 
The ocs API was just exiting with a fatal error on any update request,
when configured for the cs3 backend. Now it returns a proper error.

Closes: owncloud#3483
rhafer added a commit to rhafer/ocis that referenced this issue Apr 20, 2022
@rhafer
return proper errors when ocs/cloud/users is using the cs3 backend
605f8a5 
The ocs API was just exiting with a fatal error on any update request,
when configured for the cs3 backend. Now it returns a proper error.

Closes: owncloud#3483
rhafer added a commit to rhafer/ocis that referenced this issue Apr 20, 2022
@rhafer
return proper errors when ocs/cloud/users is using the cs3 backend
916b2bb 
The ocs API was just exiting with a fatal error on any update request,
when configured for the cs3 backend. Now it returns a proper error.

Closes: owncloud#3483
@rhafer rhafer mentioned this issue Apr 20, 2022
Merged
@micbar micbar mentioned this issue May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return proper errors when ocs/cloud/users is using the cs3 backend rhafer/ocis
2 participants
@rhafer @kiranparajuli589