-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No quota exceeded message for oCIS spaces #5449
Comments
@phil-davis cover with API tests? |
@saw-jan are there ocis API tests that try to upload files exceeding quota, and that check that the response contains a useful status and message? If not, then we should add API tests. Do they pass? If so, then I guess that the problem is with the client not ocis. |
There is this API test scenario for insufficient quota. ocis/tests/acceptance/features/apiSpaces/quota.feature Lines 41 to 44 in 390813b
|
OK. So the problem might be that https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/507 "507 Insufficient Storage" is a well-known HTTP status code, but it is a "500"-series code. So a client might interpret all @saw-jan can you post the response to a That will help the client devs to see what the client code does with a response like that. |
The oCIS responds like this: curl -XPUT "https://host.docker.internal:9200/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%241970824f-4c74-4812-aedb-786a7b5d1901/epsum.txt" \
-d"exceeds quota" -uadmin:admin -vk < HTTP/1.1 507 Insufficient Storage
< Access-Control-Allow-Origin: *
< Content-Length: 0
< Content-Security-Policy: default-src 'none';
< Date: Tue, 24 Jan 2023 09:44:05 GMT
< X-Content-Type-Options: nosniff
< X-Download-Options: noopen
< X-Frame-Options: SAMEORIGIN
< X-Permitted-Cross-Domain-Policies: none
< X-Robots-Tag: none
< X-Xss-Protection: 1; mode=block
<
* Connection #0 to host host.docker.internal left intact |
This problem is not visible for curl Descriptionfix HTTP1.1 RFC 2616 for bodies when we issue a 507 because of quota exceeded from RFC 2616:
see also |
The fix is here: cs3org/reva#3618 @micbar please have a look when you have time. |
Just for completion: The desktop client uses the |
Describe the bug
While trying to upload to the space exceeding its quota, the useful error message is not shown. Instead,
Connection closed
error message is shown.Expected behavior
Expected to see an error message regarding quota exceeded
Steps to reproduce the issue
1GB
)Screenshots
oCIS server log:
Client version number
3.1.0.9818-rc2 e19bd4
Libraries Qt5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
Server information
oCIS 2.0.0
The text was updated successfully, but these errors were encountered: