Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocis] introduce service accounts #5550

Closed
3 tasks
exalate-issue-sync bot opened this issue Feb 10, 2023 · 5 comments
Closed
3 tasks

[ocis] introduce service accounts #5550

exalate-issue-sync bot opened this issue Feb 10, 2023 · 5 comments
Assignees
Labels
Category:Enhancement Add new functionality p3-medium Priority:p3-medium Normal priority Type:Story User Story

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Feb 10, 2023

Description

to get a better understanding what "service accounts" means please read https://github.com/owncloud/ocis/blob/master/docs/ocis/adr/0021-service-accounts.md

TODO

  • create auth provider which reads service users from a file

User Stories

  • As a ocis service i need to execute operations which need to be authenticated to other services to do background tasks when no active user is present.

Value

Acceptance Criteria

  • service accounts can authenticate against the service accounts auth provider
  • service accounts can be fitted with permissions via Roles (first iteration)

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@stale
Copy link

stale bot commented Apr 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Apr 25, 2023
@micbar micbar added the Category:Enhancement Add new functionality label Apr 25, 2023
@stale stale bot removed the Status:Stale label Apr 25, 2023
@micbar micbar added Priority:p3-medium Normal priority and removed p3-medium labels Apr 25, 2023
@kobergj kobergj self-assigned this May 31, 2023
@wkloucek
Copy link
Contributor

@kobergj does this mean the ocis storage-users trash-bin purge-expired will use the service account in the future?

@kobergj
Copy link
Collaborator

kobergj commented Aug 21, 2023

Good point. Reminds me that the storage-users commands are not tested anywhere.

Yes it will also use service-accounts.

@wkloucek
Copy link
Contributor

Yes it will also use service-accounts.

Nice!

@kobergj
Copy link
Collaborator

kobergj commented Sep 6, 2023

Landed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality p3-medium Priority:p3-medium Normal priority Type:Story User Story
Projects
Status: Done
Development

No branches or pull requests

4 participants